Unable to add Basic-theme properly #1742

4 Answer(s)

• 

  0

  learnabp created 3 years ago

  The template which is being downloaded for the Basic-Theme has a lot of issues which need resolving after it has been added to the solution

  The Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo.Tests.csproj file show contacing the following packages

  <PackageReference Include="Volo.Abp.AspNetCore.Mvc" Version="4.4.0" />
  <PackageReference Include="Volo.Abp.Autofac" Version="4.4.0" />
  <PackageReference Include="Volo.Abp.AspNetCore.TestBase" Version="4.4.0" />
  <PackageReference Include="NSubstitute" Version="4.2.2" />
  <PackageReference Include="Shouldly" Version="4.0.3" />
  <PackageReference Include="xunit" Version="2.4.1" />
  <PackageReference Include="xunit.extensibility.execution" Version="2.4.1" />
  <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
  <PackageReference Include="Microsoft.NET.Test.Sdk" Version="$(MicrosoftNETTestSdkPackageVersion)" />
  

  especially the following

  <PackageReference Include="Volo.Abp.AspNetCore.Tests" Version="4.4.0" />

  should be replaced with

  <PackageReference Include="Volo.Abp.AspNetCore.TestBase" Version="4.4.0" />

  the following lines also need to be added to AbpAspNetCoreMvcUiBootstrapDemoTestBase.cs file of Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo.Tests.csproj project

  public abstract class AbpAspNetCoreMvcUiBootstrapDemoTestBase : AbpAspNetCoreTestBase<TestStartup>

  to

  public abstract class AbpAspNetCoreMvcUiBootstrapDemoTestBase : AbpAspNetCoreIntegratedTestBase<TestStartup>

  the following lines also need to be added to AbpAspNetCoreMvcUiBootstrapDemoTestBase.cs file of Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo.Tests.csproj project

      protected virtual async Task<string> GetResponseAsStringAsync(string url, HttpStatusCode expectedStatusCode = HttpStatusCode.OK)
      {
          using (var response = await GetResponseAsync(url, expectedStatusCode))
          {
              return await response.Content.ReadAsStringAsync();
          }
      }
  
      protected virtual async Task<HttpResponseMessage> GetResponseAsync(string url, HttpStatusCode expectedStatusCode = HttpStatusCode.OK)
      {
          using (var requestMessage = new HttpRequestMessage(HttpMethod.Get, url))
          {
              requestMessage.Headers.Add("Accept-Language", CultureInfo.CurrentUICulture.Name);
              var response = await Client.SendAsync(requestMessage);
              response.StatusCode.ShouldBe(expectedStatusCode);
              return response;
          }
      }
  

  the file AbpAspNetCoreMvcUiBootstrapDemoTestBase.cs should be as follows

  using System;
  using System.Globalization;
  using System.IO;
  using System.Linq;
  using System.Net;
  using System.Net.Http;
  using System.Threading.Tasks;
  using Microsoft.AspNetCore.Hosting;
  using Microsoft.Extensions.Hosting;
  using Shouldly;
  using Volo.Abp.AspNetCore.TestBase;
  
  namespace Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo
  {
      public abstract class AbpAspNetCoreMvcUiBootstrapDemoTestBase : AbpAspNetCoreIntegratedTestBase<TestStartup>
      {
          protected override IHostBuilder CreateHostBuilder()
          {
              return base.CreateHostBuilder()
                  .UseContentRoot(CalculateContentRootPath());
          }
  
          private static string CalculateContentRootPath()
          {
              return CalculateContentRootPath(
                  "Volo.Abp.sln",
                  $"test{Path.DirectorySeparatorChar}Volo.Abp.AspNetCore.Mvc.UI.Bootstrap.Demo"
              );
          }
  
          private static string CalculateContentRootPath(
              string testFileNameInTheRootFolder,
              string relativeContentPath)
          {
              var currentDirectory = Directory.GetCurrentDirectory();
              while (!ContainsFile(currentDirectory, testFileNameInTheRootFolder))
              {
                  currentDirectory = new DirectoryInfo(currentDirectory).Parent.FullName;
              }
  
              if (!relativeContentPath.IsNullOrWhiteSpace())
              {
                  currentDirectory = Path.Combine(currentDirectory, relativeContentPath);
              }
  
              return currentDirectory;
          }
  
          private static bool ContainsFile(string currentDirectory, string projectFileName)
          {
              return Directory
                  .GetFiles(currentDirectory, "*.*", SearchOption.TopDirectoryOnly)
                  .Any(f => Path.GetFileName(f) == projectFileName);
          }
  
          protected virtual async Task<string> GetResponseAsStringAsync(string url, HttpStatusCode expectedStatusCode = HttpStatusCode.OK)
          {
              using (var response = await GetResponseAsync(url, expectedStatusCode))
              {
                  return await response.Content.ReadAsStringAsync();
              }
          }
  
          protected virtual async Task<HttpResponseMessage> GetResponseAsync(string url, HttpStatusCode expectedStatusCode = HttpStatusCode.OK)
          {
              using (var requestMessage = new HttpRequestMessage(HttpMethod.Get, url))
              {
                  requestMessage.Headers.Add("Accept-Language", CultureInfo.CurrentUICulture.Name);
                  var response = await Client.SendAsync(requestMessage);
                  response.StatusCode.ShouldBe(expectedStatusCode);
                  return response;
              }
          }
  
      }
  }
  

  Please return my ticket

  let me know when you have fixed basic-theme template so I can add it to my solution again and test

  Save Cancel
• 

  0

  maliming created 3 years ago

  Support Team Fullstack Developer

  https://github.com/abpframework/abp/pull/9750

  Save Cancel
• 

  0

  maliming created 3 years ago

  Support Team Fullstack Developer

  

  Save Cancel
• 

  0

  ServiceBot created 3 years ago

  Support Team Automatic process manager

  This question has been automatically marked as stale because it has not had recent activity.

  Save Cancel