How to initialize Quartz in integration testing #1847

5 Answer(s)

• 

  0

  berkansasmaz created 3 years ago

  Support Team .NET Developer

  Hi,

  The point we are trying to test here should not be Quartz. Currently your tests depend on Quartz, ie the behavior of a library, but this is not a good method.

  In my view changing your Execute method as follows provides a more testable environment:

          public override async Task Execute(IJobExecutionContext context)
          {
              Logger.LogInformation("Starting:  EventReminderWorker...");
  
              
              // It might be better to write tests for this service
              await ServiceProvider
                  .GetRequiredService<YourOperationService>() 
                  .EventReminder();
              
              
              Logger.LogInformation("Completed: EventReminderWorker...");
          }
  

  Save Cancel
• 

  0

  LW created 3 years ago

  Hello, thank you for your answer. I wasn't quite clear on what I was testing. I'm not trying to test the Quarz library, I'm just using it as a tool in my test to assert my logic.

  public Ctor(Guid tenantId, string tenantName, string scheduleDefinition)
  		{
  			Check.NotNullOrEmpty(tenantName, nameof(tenantName));
              Check.NotNullOrEmpty(scheduleDefinition, nameof(scheduleDefinition));
  
  			JobDataMap jobDataMap = new()
  			{
  				{ "TenantId", tenantId }
  			};
  			JobDetail = JobBuilder.Create<ScheduledControlValueCalculationBackgroundWorker>()
  				.WithIdentity(TenantSpesificBackgoundProcessNameFormat.GetFormattedName(this, tenantName))
  				.SetJobData(jobDataMap)
  				.Build();
  			Trigger = TriggerBuilder.Create()
  				.WithIdentity(TenantSpesificBackgoundProcessNameFormat.GetFormattedName(this, tenantName))
  				/* 
  				 * Put the schedule to the definition and do the rescheduling based on that info. No other easy way to check
  				 * if the triggers are really the same. 
  				 */
  				.WithDescription(scheduleDefinition)
  				.WithCronSchedule(scheduleDefinition, options => options.WithMisfireHandlingInstructionFireAndProceed() )
  				.Build();
  			
  			ScheduleJob = async scheduler =>
  			{
  				if (!await scheduler.CheckExists(JobDetail.Key))
  				{
  					await scheduler.ScheduleJob(JobDetail, Trigger);
  				}
  				else
  				{
  					// If the job already exists there might be changes to the schedule so reschedule the job if so
  					IJobDetail jobDetail = await scheduler.GetJobDetail(JobDetail.Key);
  					
  					var trigger = await scheduler.GetTrigger(Trigger.Key);
  					if(trigger.Description != Trigger.Description)
  					{
  						await scheduler.RescheduleJob(trigger.Key, Trigger);
  					}
  				}
  			};
  		}
  

  Save Cancel
• 

  0

  liangshiwei created 3 years ago

  Support Team Fullstack Developer

  Hi,

  See https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.Quartz/Volo/Abp/Quartz/AbpQuartzModule.cs#L69

  You can get existing instances from the DI container

  Save Cancel
• 

  0

  LW created 3 years ago

  Hi, that won't matter. For some reason the module initalization tries to initialize the scheduler twice if I have two tests. The problem is in the initalization, not in how I get the scheduler in my tests.

  Save Cancel
• 

  0

  liangshiwei created 3 years ago

  Support Team Fullstack Developer

  Hi,

  Can you proivde steps to reproduce it? it will be better if you can provide a simple project, thanks.

  Save Cancel