Thank you for reply.
However I've just checked out that canActivate is not triggered when I reload my root page, i.e. it is not responsible for showing/hiding menu items:
Question 1) what ABP service/method is actually used to decide what to show or hide in the menu?
Question 2) meanwhile to save time while waiting for your reply I decided to make a server method (the result is supposed to be cached in Angular client) which returns mapping between module IDs and their permissions. Is it a correct approach? I've tried to use PermissionAppService.GetAsync() directly inside the loop, but it is very slow:
public virtual async Task<Dictionary<string, IEnumerable<string>>> GetModuleRolePermissionMapAsync()
{
var moduleRoleNames = await _modulePermissionChecker.GetModuleRoleNamesAsync(CurrentTenant.Id, CurrentUser.Id, CurrentUser.IsAuthenticated);
var result = new Dictionary<string, IEnumerable<string>>();
using (CurrentTenant.Change(null))
{
var permissionGrants = await _permissionGrantRepository.GetListAsync();
result = moduleRoleNames.GroupJoin
(
permissionGrants.Where(pg => pg.ProviderName == RolePermissionValueProvider.ProviderName),
moduleRoleName => moduleRoleName,
permissionGrant => permissionGrant.ProviderKey,
(moduleRoleName, permissionGrants) => (moduleRoleName, permissionGrantNames: permissionGrants.Select(x => x.Name))
)
.ToDictionary(x => x.moduleRoleName, x => x.permissionGrantNames);
}
return result;
}
The mechanism we implemented is an advanced role permission check - with an intermediate layer added. It replaces the standard ABP role mechanism, so would be logically to override client-side permission check instead of adding something new (at back-end we replaced Role Provider). Moreover, we don't want to write a new guard from scratch, because most of the functionality of ABP PermissionGuard fits us.
So, is it possible to override PermissionGuard keeping in mind the following requirement:
considering the following route data for "Page 1":
{ moduleId: "Module 1", requiredPolicy: "Permission 1" }this page needs to be visible in the menu only if server finds "Permission 1" among all permissions assigned to "Module 1"
?
I see two problems here:
moduleId present in our route (using interceptor or whatever) and I will be able to read this information from request inside public override async Task<MultiplePermissionGrantResult> CheckAsync(PermissionValuesCheckContext context) - the output parameter signature for this method does not suppose something besides permission. It supposes the permission is either granted or not. In our case, the same permission may be granted to one module id (and then the corresponding page is shown) and revoked to another module id...grantedPolicies parameter for the overriden ABP PermissionService at client-side (I suppose this service makes decision if the specific page is shown in the menu), I am not sure I will make things work in general, probably you may tell me:
Record<string, boolean> needs to become Record<string + string, boolean> ("permission A" is granted or revoked for "module A")UPDATE: what I have additionally discovered is that I cannot control ABP pages permissions - the pages which I have not overriden. It's weird or I'm missing something:
Permission check of such pages in custom PermissionValueProvider does not happen, i.e. CheckAsync is not triggered...
I've implemented Module Role conception. Module Role is bound to a Module ID, It's like a unique identifier of Angular app page. A Module Role is filled with ordinary permissions. At the same time, a group of Module Roles can be assigned to an ordinary role. This conception works as expected for per-page access, when a page is accessed via menu, because Module ID is passed to back-end and I can check if there specific page has three requested permissions.
However, it doesn't work properly when I load the app and expect to see only those pages in the menu whose Module ID has the required permission for this page.
So the question is how to pass-through additional information of route (like this module ID) from Angular app to a back-end:
when I load the specific page via URL:
or just navigating to the app https://localhost:4200 (and expecting to see only specific module ID-related pages in the menu)
to have it available in any possible way (via DI request object, etc.) inside your method:
public override async Task<MultiplePermissionGrantResult> CheckAsync(PermissionValuesCheckContext context)
?
https://docs.abp.io/en/abp/latest/Localization#extending-existing-resource
You can override existing localized text in different solutions
Thank you - I will try to make use of the including basic type into any empty resource class of ModulePermission class. Hope it will work out.
Could you please let me know if it is possible to pass-through additional information of route (like this module ID) from Angular app somehow to a back-end?
when I am loading the specific page via URL:
or just navigating to the app https://localhost:4200 (and expecting to see only specific module ID-related pages in the menu)
inside your method:
public override async Task<MultiplePermissionGrantResult> CheckAsync(PermissionValuesCheckContext context)
? I need information about all module IDs (module ID matches Module Role, which contains permissions) for my Angular app pages to check out which of them are to be displayed / hidden.
My teammate mentioned that "dynamic permissions" do not fit us for some reasons. I don't know the details yet, I will get back to this later.
Meanwhile I have the following questions.
I moved Module Role functionality into a separate solution which needs to be consumed in two different solutions, layer-by-layer: Domain.Shared, Domain, Application.Contracts, Application, EntityFramework Nuget packages, the same way as ABP solution looks like.
a) ApplicationService layer traditionally contains some localized information:
public class ModulePermissionAppService : ApplicationService, IModulePermissionAppService
And I need to customize resource localization in the places like this:
throw new BusinessException(DomainErrorCodes.NotFound, _stringLocalizer.GetString("Roles:RoleNotFound"));
i.e. dependency-injected _stringLocalizer which is IStringLocalizer<SomeResource> needs to have different value in each case. For instance, IStringLocalizer<ResourceA> in one solution and IStringLocalizer<ResourceB> in another solution. How do I do that?
b) I'd like to pass Authorization Permission class constants in some nice uniform way:
[Authorize(THIS_NEEDS_TO_BE_CUSTOMIZED.Roles.Modify)] //
public async Task DeleteRoleAsync(bool isModuleRole, Guid id, bool ignoreDeleted = false)
[Authorize(THIS_NEEDS_TO_BE_CUSTOMIZED.Roles.Read)] //
public async Task<RoleDto> GetRoleAsync(Guid id)
I guess the
IsDeletedfield value of one of them is true Could be, I've deleted the duplicate and cannot check it out...
The implementation is almost complete. I have the following question.
Let's say my new Role Management page is located in Solution A which has this page in UI. However, I want to assign and revoke granted permissions for other Solutions, each of them has own PermissionDefinition.
How to do that? Indeed, Solution A does not have references to another solutions, particularly. it does not have references to Solution B Application Contracts project, where definitions are described. So the "Role Management" page in Solution A does not list the permissions from Solution B and thus cannot assign or revoke them.
Thank you. Overriding AppService is ok too.
Could you please tell me if it can be considered a bug?
Why ABP allowed me to create two roles with the same name for null-tenant? ABPROLES does not have constraint for [TENANTID, NAME], but I can't figure it out how to make use of two roles with the same name for the same tenant...
You can replace the component with yours and use the your own service to get roles. https://docs.abp.io/en/abp/latest/UI/Angular/Component-Replacement
I already use a DepartmentComponent instead of ABP OrganizationUnitsComponent.
It generally "mimics" the ABP "Organization Units" component behavior.
The problem is that when on "Roles" tab you click "Add Role" - modal component OrganizationRolesModalBodyComponent is shown which itself is NOT replaceable. It uses the following service to fill the list of roles:
The only way to affect this list that I can see it to replace dependency-injected service IdentityRoleService. However, as I have written before, I don't know how to do it properly (if possible).
You can override the repository to filter the roles.
This approach does not suit me well. I already use ABP EfCoreIdentityRoleRepository in many places of my solutions. I'd prefer to leave ABP EfCoreIdentityRoleRepository intact, but instead replace client-side ABP IdentityRoleService for specific component(s):
I've tried to inherit this service, but bumped into the problem: for some reason ABP implementation uses arrow functions instead of prototype-level functions, so I cannot override them in my class:
There are no "MR" permissions there. I have the idea why. Meanwhile I'm going to create a separate package for optional adding Module Roles functionality to different projects. So the questions are:
a) Is it possible to have all providers on ONE layer? Because currently they are split between "Domain" and "Application.Contracts" layers following ABP source code structure. Maybe I'm missing something:
My idea is to enable this functionality in minimum of steps, i.e. just include the package to one layer (project) or to configure it in one place of one project (if possible);
b) How to filter out this query? I don't want to show "MR" roles here:
