AbpBlobContainer Duplication #2707

5 Answer(s)

• 

  0

  murat.yuceer created 2 years ago

  Also, this is my base class for backgroundjobs

  Could this be a side effect? (Notification table like hangfire queue table to track user job status)

  using Exchanger.Roles;
  using Microsoft.AspNetCore.Identity;
  using System;
  using System.Collections.Generic;
  using System.Linq;
  using System.Text;
  using System.Text.Json;
  using System.Threading.Tasks;
  using Volo.Abp.BackgroundJobs;
  using Volo.Abp.Emailing;
  using Volo.Abp.Identity;
  using Volo.Abp.MultiTenancy;
  using Volo.Abp.Timing;
  using Volo.Abp.Uow;
  
  namespace Exchanger.Ewp.Notifications
  {
      public abstract class NotificationJobBase<T> : AsyncBackgroundJob<T> where T : NotificationJobArgs
      {
          public ICurrentTenant CurrentTenant { get; set; }
          public IUnitOfWorkManager UnitOfWorkManager { get; set; }
          public INotificationRepository NotificationRespository { get; set; }
          public IClock Clock { get; set; }
          public IEmailSender EmailSender { get; set; }
          public IIdentityUserRepository IdentityUserRepository { get; set; }
          public ILookupNormalizer LookupNormalizer { get; set; }
  
          protected abstract Task JobMethod(T args);
  
          public override async Task ExecuteAsync(T args)
          {
              using (CurrentTenant.Change(args.CurrentTenantId, args.CurrentTenantName))
              {
                  Exception jobException = null;
                  Notification notification = null;
  
                  using (var uow = UnitOfWorkManager.Begin(requiresNew: true, isTransactional: false))
                  {
                      //get job related notification data
                      notification = await NotificationRespository.FindAsync(args.NotificationId);
                      if (notification == null)
                          return;
  
                      if (notification.ProcessState == NotificationJobState.Cancel ||
                          notification.ProcessState == NotificationJobState.InProcess ||
                          notification.ProcessState == NotificationJobState.Completed)
                          return;
                      notification.SetState(NotificationJobState.InProcess);//to show user job working
                      await NotificationRespository.UpdateAsync(notification);
                      await uow.CompleteAsync();
                  }
  
  
  
  
  
                  bool isError = false;
                  var uowJob = UnitOfWorkManager.Begin(requiresNew: true, isTransactional: true);
                  try
                  {
                      await JobMethod(args); // <== this is actual job method overrided from parent class
  
                      notification.AddTransactionHistory(new Transaction(Clock.Now)
                      {
                          ProcessMessage = "Success",
                          IsSuccess = true
                      });
  
                      await uowJob.CompleteAsync();
                  }
                  catch (Exception ex)
                  {
                      jobException = ex;
  
                      notification.AddTransactionHistory(new Transaction(Clock.Now)
                      {
                          ProcessMessage = ex.Message,
                          ProcessMessageDetail = ex.StackTrace
                      });
  
                      isError = true;
  
                      await uowJob.RollbackAsync();
                  }
                  finally
                  {
                      uowJob.Dispose();
                  }
  
  
  
  
  
                  using (var uow = UnitOfWorkManager.Begin(requiresNew: true, isTransactional: false))
                  {
                      if (!notification.ManuallyTriggered)
                          await SendEmail(args, isError);
  
                      if (notification.TransactionHistory.Any(p => p.IsSuccess))
                      {
                          notification.SetState(NotificationJobState.Completed);
                      }
                      else
                      {
                          notification.SetState(NotificationJobState.Fail);
                      }
  
                      await NotificationRespository.UpdateAsync(notification);
                      await uow.CompleteAsync();
                  }
  
                  //throw if exception exist for hangfire retry
                  if (jobException != null)
                      throw jobException;
              }
          }
  
          private async Task SendEmail(T args, bool isError)
          {
              ...
          }
      }
  }
  

  Save Cancel
• 

  0

  liangshiwei created 2 years ago

  Support Team Fullstack Developer

  Hi,

  This is a concurrency problem, can you try this?

  modelBuilder.Entity<DatabaseBlobContainer>(b =>
  {
      b.CollectionName = BlobStoringDatabaseDbProperties.DbTablePrefix + "BlobContainers";
      b.BsonMap.MapProperty(x => x.Name).SetIsRequired(true);
  });
  

  Save Cancel
• 

  0

  murat.yuceer created 2 years ago

  Hi,

  This is a concurrency problem, can you try this?

  modelBuilder.Entity<DatabaseBlobContainer>(b => 
  { 
      b.CollectionName = BlobStoringDatabaseDbProperties.DbTablePrefix + "BlobContainers"; 
      b.BsonMap.MapProperty(x => x.Name).SetIsRequired(true); 
  }); 
  

  Thanks, but how it will fix problem, the name was not already empty? Shouldn't we create uniqe index with name and tenantId if we are going to solve it at database level?

  Save Cancel
• 

  0

  liangshiwei created 2 years ago

  Support Team Fullstack Developer

  Hi,

  Sorry, I will check it again.

  Save Cancel
• 

  0

  liangshiwei created 2 years ago

  Support Team Fullstack Developer

  Hi,

  It this work for you?: (remove duplicate keys and run the DbMigrator project)

  public override void InitializeCollections(IMongoDatabase database)
  {
      base.InitializeCollections(database);
  
      var model = new CreateIndexModel<DatabaseBlobContainer>
      (
          "{ Name: 1 }",
          new CreateIndexOptions { Unique = true }
      );
  
      database.GetCollection<DatabaseBlobContainer>(BlobStoringDatabaseDbProperties.DbTablePrefix + "BlobContainers").Indexes.CreateOne(model);
  }
  

  Save Cancel