Can not get user's phone number into Personal Info #7235 | Support

daxabhudia created 6 months ago

ABP Framework version: v5.3
UI Type: Angular
Database System: PostgreSQL
Tiered (for MVC) or Auth Server Separated (for Angular): no
Exception message and full stack trace:
Steps to reproduce the issue:

I am using OpenIdConnect and UserInfo endpoint custom policy for authentication. After successful authentication from Azure, I got the phoneNumber into the token. In Personal Info tab, I am getting User name, Name, Surname and Email but not the Phone Number.

I am getting below claims into the token. Not sure what I am missing to get phone number value in the textbox.

17 Answer(s)

0

maliming created 6 months ago
Support Team Fullstack Developer

hi

I am using OpenIdConnect and UserInfo endpoint custom policy for authentication. After successful authentication from Azure,

Are you signed in with an existing user or create a new user?
0

daxabhudia created 6 months ago

I am signing in with new user. Also I have noted that if I update any information on Personal Info, it is not updating on to Azure side of things.
0

maliming created 6 months ago
Support Team Fullstack Developer

I am signing in with new user.

The phone number comes from the phone_number claim. Make sure the externalLoginInfo has this claim.

var externalLoginInfo = await SignInManager.GetExternalLoginInfoAsync();
0

maliming created 6 months ago
Support Team Fullstack Developer

You can override the RegisterExternalUserAsync method of RegisterModel to check the externalLoginInfo.
0

daxabhudia created 6 months ago

ok Thanks. If I update say the phone number on Azure, I am not able to get the updated phone number into Personal Info.
0

maliming created 6 months ago
Support Team Fullstack Developer

If I update say the phone number on Azure, I am not able to get the updated phone number into Personal Info.

You can update the local user phone number during Login by override the OnGetExternalLoginCallbackAsync method of LoginModel or OpenIddictSupportedLoginModel
0

daxabhudia created 6 months ago

I don't have .Web Project in my solution. Where do I override OnGetExternalLoginCallbackAsync method?
0

maliming created 6 months ago
Support Team Fullstack Developer

hi

Please share a screenshot of your project structure.

Thanks.
0

daxabhudia created 6 months ago
0

maliming created 6 months ago
Support Team Fullstack Developer

hi

Where do I override OnGetExternalLoginCallbackAsync method?

In your Repros.HttpApi.Host project
0

daxabhudia created 6 months ago

Thanks. Was able to override the OnGetExternalLoginCallbackAsync. still can't get the personal info updated for already existing users though all the claims are being retrieved properly.
0

maliming created 6 months ago
Support Team Fullstack Developer

hi

still can't get the personal info updated for already existing users though all the claims are being retrieved properly.

Please share your override code.

Thanks.

daxabhudia created 6 months ago

public override async Task<Microsoft.AspNetCore.Mvc.IActionResult> OnGetExternalLoginCallbackAsync(string returnUrl = "", string returnUrlHash = "", string remoteError = null)
{
    var loginInfo = await SignInManager.GetExternalLoginInfoAsync();

    if (loginInfo == null)
    {
        return RedirectToPage("./Login");
    }

    var result = await SignInManager.ExternalLoginSignInAsync(
        loginInfo.LoginProvider,
        loginInfo.ProviderKey,
        isPersistent: false,
        bypassTwoFactor: true
    );
    var claims = loginInfo.Principal.Claims;

    if (!result.Succeeded)
    {
        await IdentitySecurityLogManager.SaveAsync(new IdentitySecurityLogContext()
        {
            Identity = IdentitySecurityLogIdentityConsts.IdentityExternal,
            Action = "Login" + result
        });
    }

    if (result.IsLockedOut)
    {
        throw new UserFriendlyException("Cannot proceed because user is locked out!");
    }

    if (result.IsNotAllowed)
    {
        throw new UserFriendlyException("Cannot proceed because user is not allowed!");
    }

    if (result.Succeeded)
    {
        var user = await UserManager.FindByLoginAsync(loginInfo.LoginProvider, loginInfo.ProviderKey);
        if (IsLinkLogin)
        {
            using (CurrentPrincipalAccessor.Change(await SignInManager.CreateUserPrincipalAsync(user)))
            {
                await IdentityLinkUserAppService.LinkAsync(new LinkUserInput
                {
                    UserId = LinkUserId.Value,
                    TenantId = LinkTenantId,
                    Token = LinkToken
                });
            }
        }

        await IdentitySecurityLogManager.SaveAsync(new IdentitySecurityLogContext
        {
            Identity = IdentitySecurityLogIdentityConsts.IdentityExternal,
            Action = result.ToIdentitySecurityLogAction(),
            UserName = user.UserName
        });

        return RedirectSafely(returnUrl, returnUrlHash);
    }
    return RedirectSafely(returnUrl, returnUrlHash);
}

0

maliming created 6 months ago
Support Team Fullstack Developer

You can update the local user phone number during Login by override the OnGetExternalLoginCallbackAsync method of LoginModel or OpenIddictSupportedLoginModel

Where is your code for updating the local user's phone number?

daxabhudia created 6 months ago

 public override async Task<Microsoft.AspNetCore.Mvc.IActionResult> OnGetExternalLoginCallbackAsync(string returnUrl = "", string returnUrlHash = "", string remoteError = null)
        {
            var loginInfo = await SignInManager.GetExternalLoginInfoAsync();

            if (loginInfo == null)
            {
                return RedirectToPage("./Login");
            }

            var result = await SignInManager.ExternalLoginSignInAsync(
                loginInfo.LoginProvider,
                loginInfo.ProviderKey,
                isPersistent: false,
                bypassTwoFactor: true
            );

            if (!result.Succeeded)
            {
                await IdentitySecurityLogManager.SaveAsync(new IdentitySecurityLogContext()
                {
                    Identity = IdentitySecurityLogIdentityConsts.IdentityExternal,
                    Action = "Login" + result
                });
            }

            if (result.IsLockedOut)
            {
                throw new UserFriendlyException("Cannot proceed because user is locked out!");
            }

            if (result.IsNotAllowed)
            {
                throw new UserFriendlyException("Cannot proceed because user is not allowed!");
            }

            if (result.Succeeded)
            {
                var user = await UserManager.FindByLoginAsync(loginInfo.LoginProvider, loginInfo.ProviderKey);
                user.Name = loginInfo.Principal.FindFirstValue(AbpClaimTypes.Name);
                user.Surname = loginInfo.Principal.FindFirstValue(AbpClaimTypes.SurName);
                var phoneNumber = loginInfo.Principal.FindFirstValue(AbpClaimTypes.PhoneNumber);
                if (!phoneNumber.IsNullOrWhiteSpace())
                {
                    var phoneNumberConfirmed =         string.Equals(loginInfo.Principal.FindFirstValue(AbpClaimTypes.PhoneNumberVerified), "true", StringComparison.InvariantCultureIgnoreCase);
                    user.SetPhoneNumber(phoneNumber, phoneNumberConfirmed);
                }

                await UserManager.UpdateAsync(user);

                if (IsLinkLogin)
                {
                    using (CurrentPrincipalAccessor.Change(await SignInManager.CreateUserPrincipalAsync(user)))
                    {
                        await IdentityLinkUserAppService.LinkAsync(new LinkUserInput
                        {
                            UserId = LinkUserId.Value,
                            TenantId = LinkTenantId,
                            Token = LinkToken
                        });
                    }
                }

                await IdentitySecurityLogManager.SaveAsync(new IdentitySecurityLogContext
                {
                    Identity = IdentitySecurityLogIdentityConsts.IdentityExternal,
                    Action = result.ToIdentitySecurityLogAction(),
                    UserName = user.UserName
                });

                return RedirectSafely(returnUrl, returnUrlHash);
            }
            return RedirectSafely(returnUrl, returnUrlHash);
        }

0

daxabhudia created 6 months ago

updated OnGetExternalLoginCallbackAsync with the code to update name, surname and phone number when user logs in. It is working ok and able to update the local db.
0

maliming created 6 months ago
Support Team Fullstack Developer

ok, Can you set a breakpoint to see if your code is executed?

Have an answer to this question? Log in and write your answer.