There is another issue in the generated EfCoreEntityRepository.cs class
The issue corresponds to the **FindAsync **method inside the **EfCoreRepository ** class
There seems to be a problem between the nullable-enabled project and the non-enabled nullable project (EntityFramework Project). One method returns a nullable type while the other expects a non-nullable return value.
This is a critical error for the new version.
3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match member "Task<Ubigeo?> IRepository<Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" implemented implicitly.
3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match the implicitly implemented member "Task<Ubigeo?> IReadOnlyBasicRepository<Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))".
3>------- Finished building project: D.EntitemoyFrameworkCore. Succeeded: False. Errors: 2. Warnings: 0
This situation happen also in the Geo.Extended.cs class in the Domain Project
The constructor generated in the base class as the extended class are generated properties with the same problem (for nullable properties)
"string codigoInei = null"
instead of
"string? codigoInei = null"
ABP Suite still generates EntityManager generated class with methods without null validation checking
In this example the GeoManager class is generating a Create Method with a parameter of type "string codigoInei = null".
It should be "string? codigoInei = null". This complicates us if I want to re-generate the ABP Suite. I will need to fix everytime.
There are a couple of missing "?" in this template too
In the same template, this "filterText" should be nullable too
Also, I noticed that this template lacks a couple of "?" in some nullable string parameters.
Hi again, this is your friend Rafael :)
In this template, can we replace the #pragma warning disable CS8618 for a null forgiven or required operator approach?
There is an issue with the version 7.4 rc-3.
I have an issue with the following packages that couldn't be restored with this version
Unable to find package Volo.CmsKit.Pro.Common.Web. No packages exist with this id in source(s): ABP Commercial NuGet Source, C:\Program Files\dotnet\library-packs, C:\Program Files\dotnet\sdk\7.0.307\Sdks\Microsoft.NET.Sdk.Web\library-packs, Microsoft Visual Studio Offline Packages, nuget.org
Hello, are there any comments regarding my findings?
In the ABP Suite generated code, there is a massive abuse of the #pragma warning disable CS8618
Instead of disabling the warnings, can we replace those with the "required" modifier to follow a more organic approach?
A solution is suggested.
In the ABP Suite Generated code, there is an issue in the generated class test/Demo74rc1.TestBase/EntityDemos/EntityDemosDataSeedContributor.cs
Do we need a null validation in await _unitOfWorkManager.Current.SaveChangesAsync(); ?
Current property is nullable and there will be a warning or error (if WarningAsNull is activated)
