LocalEventBus Issues #9032

gizem.kip created 8 days ago

Hello,
I'm currently working with local events in my project but I have faced 2 issues.

First one, even I set the onUnitOfWorkComplete parameter as false still the task is waiting for to complete unit of work task. My only solution is removing "await" on publichAsync. Detail is as below.

Working:

                LocalEventBus.PublishAsync(
                    new ImportXmlEvent
                    {
                        IncomingFileId = input.IncomingModelFileId,
                        SourceName = input.SourceName,
                        ModelId = id,
                        CorrelationId = HttpContextAccessor.HttpContext?.TraceIdentifier
                    },false);

Doesn't Work:

 await LocalEventBus.PublishAsync(
                    new ImportXmlEvent
                    {
                        IncomingFileId = input.IncomingModelFileId,
                        SourceName = input.SourceName,
                        ModelId = id,
                        CorrelationId = HttpContextAccessor.HttpContext?.TraceIdentifier
                    },false);`

Second issue, after event published, even event handler method is virtual still it is not working correctly without using _unitOfWorkManager as below. Without using _unitOfWorkManager, child entities is not commiting to the db.

Working:

  [UnitOfWork]
        public virtual async Task HandleEventAsync(ImportXmlEvent eventData)
        {
            using (var uow = _unitOfWorkManager.Begin(requiresNew: true, isTransactional: true)) 
            {
                ...
             }
            }

Database System: EF Core (SQL Server)

EngincanV created 7 days ago

Support Team .NET Developer

Hi, your finding that removing await allows the event to be published immediately when onUnitOfWorkComplete is false seems to be the correct workaround. Because, since you are not using the await keyword, it works like a sync method. But just notice, when you do that in an unhandled exception occurs then you are on your own in exception handling.

Second issue, after event published, even event handler method is virtual still it is not working correctly without using _unitOfWorkManager as below. Without using _unitOfWorkManager, child entities is not commiting to the db.

By using _unitOfWorkManager.Begin(requiresNew: true, isTransactional: true), you are explicitly creating a new and independent unit of work for the duration of your event handler's execution. This ensures that all operations within this using block, including changes to child entities, are tracked by EF Core within this specific unit of work.

Actually, since you are using the [UnitOfWork] attribute, normally it should work seamlessly but it's possible that the event handler is being invoked in a context where the ambient unit of work has already been completed or disposed, or perhaps the event handling mechanism in this specific scenario doesn't correctly hook into the ambient unit of work management for child entities. I'll check this.

Regards.