Entity extending with DateOnly property is not working #9041

papusa created 8 days ago

Hi!
I need to add a couple of extra properties to the IdentityUser. One of these properties will represent the date of birth, and I would like its type to be DateOnly.

Below is my current code:
EfCoreEntityExtensionMappings

            ObjectExtensionManager.Instance.MapEfCoreProperty`<IdentityUser, string>`(
                UserExtraPropertyNames.NationalIdentityNumber,
                (_, propertyBuilder) =>
                {
                    propertyBuilder.IsRequired();
                    propertyBuilder.HasColumnType("varchar(11)");
                });

            ObjectExtensionManager.Instance.MapEfCoreProperty`<IdentityUser, DateOnly>`(
                UserExtraPropertyNames.BirthDate,
                (_, propertyBuilder) =>
                {
                    propertyBuilder.IsRequired();
                });

ExtensionConfigurator

ObjectExtensionManager.Instance.Modules().ConfigureIdentity(identity =>
        {
            identity.ConfigureUser(user =>
            {
                user.AddOrUpdateProperty`<string>`(UserExtraPropertyNames.NationalIdentityNumber, property =>
                {
                    property.Attributes.Add(new RequiredAttribute());
                    property.Attributes.Add(new StringLengthAttribute(11) { MinimumLength = 11 });
                });
                
                user.AddOrUpdateProperty`<DateOnly>`(UserExtraPropertyNames.BirthDate, property =>
                {
                    property.DefaultValueFactory = () => DateOnly.FromDateTime(DateTime.Today);
                    
                    property.Validators.Add(context =>
                    {
                        
                    });
                });
            });
        });

The BirthDate property is never set and always has the default value of 0001-01-01 when a new user is created. I believe the issue is related to type casting. The BirthDate property has a DateTime type instead of DateOnly, which might be causing the problem.

Do you have any suggestions on how I can fix this?

Thanks!

EngincanV created 8 days ago

Support Team .NET Developer

Hi, thanks for the detailed information. Your code for extending the IdentityUser with a DateOnly property for BirthDate looks correct at first glance. ABP's entity extension mechanism should handle this. However, the fact that the property always defaults to 0001-01-01 suggests that the value is indeed not being set during user creation.

Your suspicion about type casting is likely on the right track. You can try to explicitly configure column type in mapping as follows:

ObjectExtensionManager.Instance.MapEfCoreProperty<IdentityUser, DateOnly>(
                UserExtraPropertyNames.BirthDate,
                (_, propertyBuilder) =>
                {
                    propertyBuilder.IsRequired();
                    propertyBuilder.HasColumnType("date");
                });

By explicitly setting the column type (propertyBuilder.HasColumnType("date")), I think your problem should be resolved. Can you try it and let me know if it fixes, please?

papusa created 7 days ago

It didn't work. I believe the issue is not related to the EF type, as the migration already has the correct SQL type. It seems to be caused by a deserialization or mapping step in the pipeline. Since extra property values are stored as Object, it could be a boxing issue. When replacing IdentityUserAppService, I noticed that the BirthDate property is stored as DateTime instead of DateOnly. Additionally, the response includes a time part, which suggests unintended type conversion.
Request:

{
 "extraProperties": {
   "NationalIdentityNumber": "12345678901",
   "BirthDate": "2001-03-27" <--- no time
 },
 "userName": "test",
 "name": "test",
 "surname": "test",
 "password": "test123",
 "email": "test@test",
 "phoneNumber": "",
 "isActive": true,
 "lockoutEnabled": true,
 "emailConfirmed": false,
 "phoneNumberConfirmed": false,
 "shouldChangePasswordOnNextLogin": false,
 "roleNames": [],
 "organizationUnitIds": []
}

Response:

{
    "tenantId": null,
    "userName": "test",
    "email": "test@test",
    "name": "test",
    "surname": "test",
    "emailConfirmed": false,
    "phoneNumber": "",
    "phoneNumberConfirmed": false,
    "supportTwoFactor": false,
    "twoFactorEnabled": false,
    "isActive": true,
    "lockoutEnabled": true,
    "isLockedOut": false,
    "lockoutEnd": null,
    "shouldChangePasswordOnNextLogin": false,
    "concurrencyStamp": "6d0c02c007114cfa8a6eb816bd9f277c",
    "roleNames": null,
    "accessFailedCount": 0,
    "lastPasswordChangeTime": "2025-03-27T07:16:52.8335677+00:00",
    "isExternal": false,
    "isDeleted": false,
    "deleterId": null,
    "deletionTime": null,
    "lastModificationTime": null,
    "lastModifierId": null,
    "creationTime": "2025-03-27T09:16:52.8579278+02:00",
    "creatorId": "519c6b51-3e6f-8cb8-cade-3a17de0dafb7",
    "id": "51e457a2-1a1e-5930-a2d4-3a18e8a2d980",
    "extraProperties": {
        "BirthDate": "2001-03-27T00:00:00", <---- time added
        "NationalIdentityNumber": "12345678901"
    }
}

This is how I see the problem:

Incorrect type casting in the pipeline.
The date is not saved in the database due to the wrong type, but no error is thrown; instead, a default value is set.
The response includes the user’s input, but time is added to date.

Btw, on UI date input is a simple text input, not a date picker.

EngincanV created 7 days ago

Support Team .NET Developer

It didn't work. I believe the issue is not related to the EF type, as the migration already has the correct SQL type. It seems to be caused by a deserialization or mapping step in the pipeline. Since extra property values are stored as Object, it could be a boxing issue. When replacing IdentityUserAppService, I noticed that the BirthDate property is stored as DateTime instead of DateOnly. Additionally, the response includes a time part, which suggests unintended type conversion.
Request:
{ 
 "extraProperties": { 
   "NationalIdentityNumber": "12345678901", 
   "BirthDate": "2001-03-27" <--- no time 
 }, 
 "userName": "test", 
 "name": "test", 
 "surname": "test", 
 "password": "test123", 
 "email": "test@test", 
 "phoneNumber": "", 
 "isActive": true, 
 "lockoutEnabled": true, 
 "emailConfirmed": false, 
 "phoneNumberConfirmed": false, 
 "shouldChangePasswordOnNextLogin": false, 
 "roleNames": [], 
 "organizationUnitIds": [] 
} 
Response:
{ 
    "tenantId": null, 
    "userName": "test", 
    "email": "test@test", 
    "name": "test", 
    "surname": "test", 
    "emailConfirmed": false, 
    "phoneNumber": "", 
    "phoneNumberConfirmed": false, 
    "supportTwoFactor": false, 
    "twoFactorEnabled": false, 
    "isActive": true, 
    "lockoutEnabled": true, 
    "isLockedOut": false, 
    "lockoutEnd": null, 
    "shouldChangePasswordOnNextLogin": false, 
    "concurrencyStamp": "6d0c02c007114cfa8a6eb816bd9f277c", 
    "roleNames": null, 
    "accessFailedCount": 0, 
    "lastPasswordChangeTime": "2025-03-27T07:16:52.8335677+00:00", 
    "isExternal": false, 
    "isDeleted": false, 
    "deleterId": null, 
    "deletionTime": null, 
    "lastModificationTime": null, 
    "lastModifierId": null, 
    "creationTime": "2025-03-27T09:16:52.8579278+02:00", 
    "creatorId": "519c6b51-3e6f-8cb8-cade-3a17de0dafb7", 
    "id": "51e457a2-1a1e-5930-a2d4-3a18e8a2d980", 
    "extraProperties": { 
        "BirthDate": "2001-03-27T00:00:00", <---- time added 
        "NationalIdentityNumber": "12345678901" 
    } 
} 
This is how I see the problem:

Incorrect type casting in the pipeline.

The date is not saved in the database due to the wrong type, but no error is thrown; instead, a default value is set.

The response includes the user’s input, but time is added to date.

Btw, on UI date input is a simple text input, not a date picker.

Okay. I've reproduced the problem and it's exactly how you described it. I've created an issue for that: https://github.com/abpframework/abp/issues/22472

I'm refunding your ticket. Thanks for reporting the problem and your prompt explanation.

Regards.