Activities of "enes.koroglu"

Can you please share a demo or a sample code?

Hi @maliming

We are trying to go live and this mistake preventing us. We need urgent support.

Hi Anjali_Musmade,

You can find below:

{
  "Settings": {
    "Abp.Mailing.DefaultFromAddress": "noreply.information.myprojectname@mydomain.com",
    "Abp.Mailing.DefaultFromDisplayName": "MyCompany myprojectname"
  },
  "App": {
    "SelfUrl": "https://myprojectname-api.mydomain.com",
    "AngularUrl": "https://myprojectname.mydomain.com",
    "CorsOrigins": "https://*.myprojectname.com,http://localhost:4200,https://myprojectname.mydomain.com",
    "RedirectAllowedUrls": "https://myprojectname.mydomain.com",
    "DisablePII": "true",
    "HealthCheckUrl": "/health-status"
  },
  "ConnectionStrings": {
    "Default": "Host=mydb.mydomain.com;Port=5432;Database=myprojectname;User ID=myprojectname_app;Password=*******;"
  },
  "AuthServer": {
    "Authority": "https://myprojectname-api.mydomain.com",
    "RequireHttpsMetadata": "true",
    "SwaggerClientId": "myprojectname_Swagger"
  },
  "StringEncryption": {
    "DefaultPassPhrase": "*************"
  }
}

Hi @maliming

Your code (Pull Request) works on Abp 7.2, our project is Abp 5.3.3 so we had to change some codes. I changed IdentityUserRepository variable's type from IIdentityUserRepository to IRepository<IdentityUser>. And did a second change on using IdentityUserRepository like below:

//var users = await IdentityUserRepository.GetListByIdsAsync(userGroup.Select(x => x.TargetUserId));
//changed above code like below
var users = (await IdentityUserRepository.GetQueryableAsync())
          .Where(p => userGroup.Select(p => p.TargetUserId).Contains(p.Id)).ToList();

In this scenario operation time gets to 15 seconds from 30 seconds.

We made a performance improvement on your code like below and operation time is reduced to 10 seconds from 15 seconds with this change below (increased round trip on your code):

List<IdentityUser> allUsers = new(); //added
using (dataFilter.Disable()) //added
{
    allUsers = (await IdentityUserRepository.GetQueryableAsync()) //added
              .Where(p => allLinkUsers.Select(p => p.TargetUserId).Contains(p.Id)).ToList(); //added
} //added

foreach (var userGroup in allLinkUsers.GroupBy(x => x.TargetTenantId))
{
    var tenantId = userGroup.Key;

    TenantConfiguration tenant = null;
    if (tenantId.HasValue)
    {
        tenant = await TenantStore.FindAsync(tenantId.Value);
    }

    using (CurrentTenant.Change(tenantId))
    {
        //var users = await IdentityUserRepository.GetListByIdsAsync(userGroup.Select(x => x.TargetUserId)); //commented
        //changed above line like below line
        var users = allUsers.Where(p => userGroup.Select(p => p.TargetUserId).Contains(p.Id)).ToList(); //added

        foreach (var user in users)
        {
            userDto.Add(new LinkUserDto
            {
                TargetUserId = user.Id,
                TargetUserName = user.UserName,
                TargetTenantId = tenant?.Id,
                TargetTenantName = tenant?.Name,
                DirectlyLinked = userGroup.FirstOrDefault(x => x.TargetUserId == user.Id)?.DirectlyLinked ?? false
            });
        }
    }
}

Note We reduced operation time to 10 seconds and nearly all the time is used by below code line. We inspected source of IdentityLinkUserManager.GetListAsync() method from github and this method makes too much round trips:

var linkUsers = await IdentityLinkUserManager.GetListAsync(new IdentityLinkUserInfo(currentUserId, currentTenantId), includeIndirect: true);

Sent via mail

Hi @maliming

Any news about this problem?

Hi @alper my database is on the cloud and services are working on-premises so if there is too much round trip that may cause too much latency. And for 900 records 4.5 second is not also a good time. Is it possible to change fetching all records to fetching only current page records. And also could you please check if there is a loop for user or tenant info fetch?

Hi @gizem

Did you able to test?

Hi @alper did you try on your environment? Which indices you have on AbpLinkUsers or any related table? And why getting all records on a paged page, shouldn't it fetch 10 records for paged page?

• ABP Framework version: v5.3.3
• UI type: Angular
• DB provider: EF Core
• Tiered (MVC) or Identity Server Separated (Angular): no
• Exception message and stack trace:
• Steps to reproduce the issue:"

We are creating a support account, under every tenant and we are linking these accounts each other. Now we have aproximately 50 tenant and when we open Linked Accounts modal, it takes 30 seconds. This is really slow, if the number exceeds user gets timeout (so we removed some records to be able to open Linkend Accounts screen). I realised this endpoints gets whole records, not only selected page's records and also 50 records is not too much to take 30 seconds. I think there is a problem.