FeatureAppService.GetAsync throw exception with DynamicFeatureDefinitionStore and FeatureDefinition with null Description #8998

12 Answer(s)

• 

  0

  berkansasmaz created 25 days ago

  Support Team .NET Developer

  Hi,

  I have tested the problem you mentioned both with and without description but I didn't have any problem. Here are the screenshots from my test:

  

  

  ---

  How can I reproduce your problem?

  Save Cancel
• 

  0

  Josh.Cunningham created 20 days ago

  My issue was specific to features that came from the dynamic store, so it can't be in the static store (i.e. no FeatureDefinitionProvider containing the feature in the application that is displaying the features).

  I was also viewing the features for a tenant, I didn't verify the behaviour was the same from any of the other feature management screens, but from what I've seen there's nothing to suggest this would make a difference.

  If your feature wasn't available statically, and so is definitely coming from the dynamic store, then I can try and make the time and create a minimally reproducible sample if you would like; but if this would not be a priority regardless of reproducibility then feel free to just re-close this, since the workaround for what I am observing is to just add a description this is what I have done and therefore it's no longer a very pressing issue.

  Save Cancel
• 

  0

  liangshiwei created 18 days ago

  Support Team Fullstack Developer

  I can try and make the time and create a minimally reproducible sample if you would like

  Okay, please, my email is shiwei.liang@volosoft.com

  Save Cancel
• 

  0

  Josh.Cunningham created 18 days ago

  Reproduction steps:

  1. Create solution with ABP CLI
     Exact command I used was:
     "abp new AbpTest --connection-string "Server=localhost;Database=AbpTest;Trusted_Connection=True;TrustServerCertificate=True" --version 8.2.1"

  2. Add FeatureDefinitionProvider in Application.Contracts
     Exact code I used was:

  public class TestFeatureDefinitionProvider : FeatureDefinitionProvider
  {
      public override void Define(IFeatureDefinitionContext context)
      {
          var myGroup = context.AddGroup("Test Features");
  
          var feature = myGroup.AddFeature(
              name: "Test feature 1",
              defaultValue: "true",
              displayName: new FixedLocalizableString("Test feature 1"),
              description: null,
              valueType: new ToggleStringValueType()
              );
  
          var feature2 = feature.CreateChild(
              name: "Test feature 2",
              defaultValue: "true",
              displayName: new FixedLocalizableString("Test feature 2"),
              description: null,
              valueType: new ToggleStringValueType()
              );
  
          var feature3 = myGroup.AddFeature(
              name: "Test feature 3",
              defaultValue: "true",
              displayName: new FixedLocalizableString("Test feature 3"),
              description: null,
              valueType: new ToggleStringValueType()
              );
  
      }
  }
  

  Important part here is a null description.
  3. Ran the application.
  4. Logged in, confirmed the feature management modal worked.
  5. Stopped the application.
  6. Set FeatureManagementOptions.IsDynamicFeatureStoreEnabled to true in ConfigureService of web module. Commented out FeatureDefinitionProvider I had added (to simulate a feature seeded by another application).
  7. Ran the application.
  8. Logged in, went to feature management (for host, tenant, and edition) and modal fails to load with an error dialog.

  Error in logs:

  2025-03-27 17:53:21.044 +00:00 [ERR] Value cannot be null. (Parameter 'name')
  System.ArgumentNullException: Value cannot be null. (Parameter 'name')
     at System.ArgumentNullException.Throw(String paramName)
     at Microsoft.Extensions.Localization.LocalizedString..ctor(String name, String value, Boolean resourceNotFound, String searchedLocation)
     at Microsoft.Extensions.Localization.LocalizedString..ctor(String name, String value)
     at Volo.Abp.Localization.FixedLocalizableString.Localize(IStringLocalizerFactory stringLocalizerFactory)
     at Volo.Abp.FeatureManagement.FeatureAppService.CreateFeatureDto(FeatureNameValueWithGrantedProvider featureNameValueWithGrantedProvider, FeatureDefinition featureDefinition)
     at Volo.Abp.FeatureManagement.FeatureAppService.GetAsync(String providerName, String providerKey)
     at Castle.DynamicProxy.AsyncInterceptorBase.ProceedAsynchronous[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo)
     at Volo.Abp.Castle.DynamicProxy.CastleAbpMethodInvocationAdapterWithReturnValue`1.ProceedAsync()
     at Volo.Abp.Authorization.AuthorizationInterceptor.InterceptAsync(IAbpMethodInvocation invocation)
     at Volo.Abp.Castle.DynamicProxy.CastleAsyncAbpInterceptorAdapter`1.InterceptAsync[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo, Func`3 proceed)
     at Castle.DynamicProxy.AsyncInterceptorBase.ProceedAsynchronous[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo)
     at Volo.Abp.Castle.DynamicProxy.CastleAbpMethodInvocationAdapterWithReturnValue`1.ProceedAsync()
     at Volo.Abp.GlobalFeatures.GlobalFeatureInterceptor.InterceptAsync(IAbpMethodInvocation invocation)
     at Volo.Abp.Castle.DynamicProxy.CastleAsyncAbpInterceptorAdapter`1.InterceptAsync[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo, Func`3 proceed)
     at Castle.DynamicProxy.AsyncInterceptorBase.ProceedAsynchronous[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo)
     at Volo.Abp.Castle.DynamicProxy.CastleAbpMethodInvocationAdapterWithReturnValue`1.ProceedAsync()
     at Volo.Abp.Auditing.AuditingInterceptor.ProceedByLoggingAsync(IAbpMethodInvocation invocation, AbpAuditingOptions options, IAuditingHelper auditingHelper, IAuditLogScope auditLogScope)
     at Volo.Abp.Auditing.AuditingInterceptor.InterceptAsync(IAbpMethodInvocation invocation)
     at Volo.Abp.Castle.DynamicProxy.CastleAsyncAbpInterceptorAdapter`1.InterceptAsync[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo, Func`3 proceed)
     at Castle.DynamicProxy.AsyncInterceptorBase.ProceedAsynchronous[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo)
     at Volo.Abp.Castle.DynamicProxy.CastleAbpMethodInvocationAdapterWithReturnValue`1.ProceedAsync()
     at Volo.Abp.Validation.ValidationInterceptor.InterceptAsync(IAbpMethodInvocation invocation)
     at Volo.Abp.Castle.DynamicProxy.CastleAsyncAbpInterceptorAdapter`1.InterceptAsync[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo, Func`3 proceed)
     at Castle.DynamicProxy.AsyncInterceptorBase.ProceedAsynchronous[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo)
     at Volo.Abp.Castle.DynamicProxy.CastleAbpMethodInvocationAdapterWithReturnValue`1.ProceedAsync()
     at Volo.Abp.Uow.UnitOfWorkInterceptor.InterceptAsync(IAbpMethodInvocation invocation)
     at Volo.Abp.Castle.DynamicProxy.CastleAsyncAbpInterceptorAdapter`1.InterceptAsync[TResult](IInvocation invocation, IInvocationProceedInfo proceedInfo, Func`3 proceed)
     at Volo.Abp.FeatureManagement.Web.Pages.FeatureManagement.FeatureManagementModal.OnGetAsync()
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.ExecutorFactory.GenericTaskHandlerMethod.Convert[T](Object taskAsObject)
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.ExecutorFactory.GenericTaskHandlerMethod.Execute(Object receiver, Object[] arguments)
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.InvokeHandlerMethodAsync()
     at Microsoft.AspNetCore.Mvc.RazorPages.Infrastructure.PageActionInvoker.InvokeNextPageFilterAsync()
  

  I will email you my solution as well, but above is all I did.

  Save Cancel
• 

  0

  liangshiwei created 17 days ago

  Support Team Fullstack Developer

  I will email you my solution as well, but above is all I did.

  okay

  Save Cancel
• 

  0

  Josh.Cunningham created 17 days ago

  Your email provider has rejected my email, tried with both .zip and .7z

  Please let me know if there is some other way I can drop it to you or if the steps above are sufficient

  Save Cancel
• 

  0

  liangshiwei created 15 days ago

  Support Team Fullstack Developer

  Hi,

  You can use wetransfer https://wetransfer.com/

  Save Cancel
• 

  0

  Josh.Cunningham created 14 days ago

  Sent

  Save Cancel
• 

  0

  liangshiwei created 13 days ago

  Support Team Fullstack Developer

  okay, i will check it

  Save Cancel
• 

  0

  liangshiwei created 13 days ago

  Support Team Fullstack Developer

  Hi,

  I can't reproduce the problem using the project you shared..

  My steps:

  • Run DbMigrator

  • Run Web

  • Stop web, set IsDynamicFeatureStoreEnabled to true and comment out TestFeatureDefinitionProvider

  • Run Web

  Save Cancel
• 

  0

  Josh.Cunningham created 13 days ago

  I've sent you a video following the repro steps with the issue occurring. https://we.tl/t-Ek8Ek1OI2r

  If you can't reproduce feel free to close, or you can close either way, don't think there's much more I can contribute.

  I'll be working round the issue by ensuring a description is set.

  Save Cancel
• 

  0

  liangshiwei created 3 days ago

  Support Team Fullstack Developer

  Sorry for being late.

  Could you share the video and project again? thanks.

  Save Cancel