Invalid username message not displayed #9037

geoff.hardy created 7 days ago

When attempting to save a new user with an invalid username (for example, a username with spaces), the POST users endpoint does not return a useful error message.

For example, this username is invalid due to spaces:

After pressing the Save button, the user gets an "Unknown failure has occurred" message, which is not very user friendly:

This problem appears to have been introduced when resolving this issue:

https://abp.io/support/questions/8215/Identity-module-error-handling

AbpIdentityResultExtensions.GetValuesFromError message does not find the correct error message, because the IdentityStrings values were changes in the AbpIdentityResultExtensions static constructor:

        if (IdentityStrings.ContainsKey("InvalidUserName"))
        {
            IdentityStrings["InvalidUserName"] = "Username '{0}' is invalid.";
        }

To reverse this problem, I had to do the following at the start of the Host Program:

    private static void FixIdentityResources()
    {
        var identityStrings = (typeof(AbpIdentityResultExtensions)
            .GetField("IdentityStrings", BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance)
            ?.GetValue(null) ?? new Dictionary()).As>();
        // Fix the resource strings used by AbpIdentityResultExtensions, which are changed in the AbpIdentityResultExtensions static constructor
        if (identityStrings.ContainsKey("InvalidUserName"))
        {
            identityStrings["InvalidUserName"] = "Username '{0}' is invalid, can only contain letters or digits.";
        }
    }

This results in the correct error message being displayed: