Activities of "geoff.hardy"

Thanks, this approach what I ended up doing.

It would be nice if EnsurePropertyLoadedAsync did this for us.

I have emailed you a sample project, let me know if you have any questions.

Thanks!

We are instantiating multiple AssetForm entities and then call RepositoryExtensions.EnsurePropertyLoadedAsync method to load a navigation property.

await assetFormRepository.EnsurePropertyLoadedAsync(assetForm, o => o.ConservatorField);

When we save the entities to the database, an exception is thrown:

System.InvalidOperationException: The instance of entity type 'ConservatorField' cannot be tracked because another instance with the key value '{Id: 11}' is already being tracked. When attaching existing entities, ensure that only one entity instance with a given key value is attached

The underlying problem appears to be that the underlying EFCoreRepositoruy.EnsurePropertyLoadedAsync calls ReferenceEnty.LoadAsync with LoadOptions.None.

Ideally we would like to load these navigation properties using the LoadOptions.ForceIdentityResolution, so that we do not get this problem with multiple entities being tracked.

One option would be to subclass EFCoreRepository and override the EnsurePropertyLoadedAsync method to alter the behaviour.

Is there a better option to accomplish this?

ABP:9.0.2 UI: Angular Database: EF Core Tiered: yes

When attempting to save a new user with an invalid username (for example, a username with spaces), the POST users endpoint does not return a useful error message.

For example, this username is invalid due to spaces:

After pressing the Save button, the user gets an "Unknown failure has occurred" message, which is not very user friendly:

This problem appears to have been introduced when resolving this issue:

https://abp.io/support/questions/8215/Identity-module-error-handling

AbpIdentityResultExtensions.GetValuesFromError message does not find the correct error message, because the IdentityStrings values were changes in the AbpIdentityResultExtensions static constructor:

        if (IdentityStrings.ContainsKey("InvalidUserName"))
        {
            IdentityStrings["InvalidUserName"] = "Username '{0}' is invalid.";
        }

To reverse this problem, I had to do the following at the start of the Host Program:

    private static void FixIdentityResources()
    {
        var identityStrings = (typeof(AbpIdentityResultExtensions)
            .GetField("IdentityStrings", BindingFlags.NonPublic | BindingFlags.Static | BindingFlags.Instance)
            ?.GetValue(null) ?? new Dictionary<string, string>()).As<Dictionary<string, string>>();
        // Fix the resource strings used by AbpIdentityResultExtensions, which are changed in the AbpIdentityResultExtensions static constructor
        if (identityStrings.ContainsKey("InvalidUserName"))
        {
            identityStrings["InvalidUserName"] = "Username '{0}' is invalid, can only contain letters or digits.";
        }
    }

This results in the correct error message being displayed:

Having to do this hack is not ideal.

Is there a better way to resolve this? Or is this problem likely to be fixed in a future release of ABP?

Sounds good.

It would be a nice enhancement if there was a ContentDisposition property on RemoteStreamContent to allow this to be done in the application service.

Thanks!

In our Angular front end, we would like to provide a link that returns a PDF file. We are currently returning a RemoteStreamContent:

return new RemoteStreamContent(stream, "Report.pdf", MimeTypes.Application.Pdf);

This always returns a response with the Content-Disposition header set to "attachment", causing the browser to download the file rather than view it inline in the current browser tab.

What is the recommended way of returning a file response like this with the Content-Disposition set to "inline"?

Some options considered:

1. Implementing a middleware that sets/updates the Content-Disposition header for certain API calls
2. Implementing our own custom controller

Neither of these options seem ideal, as it would be preferable to have this logic encapsulated in the application service method that returns the response.