Activities of "rafael.gonzales"

I found another bug.

No matter what combination of templates are you using within the MVC scope. When you try to add a new Module for your project. It won't add a reference for the new SubModule in the Web Project.

Hello, It's me again!

I started testing version 8.0.0 r.c-2 and I found this issue in the default template

Project Type: MVC Database: Postgresql Mobile: React Native Non-Tiered

It's missing a class with some pre-defined constants in the default template

Hello, Can we have a "Bugs & Issues" thread for v8.0.0?

Thanks maliming! I will do my best to help debug the RC!

It makes the ABP Suite load again but It keeps throwing errors.

It seems that it's trying to match the version "8.0.0-rc.1+71f937d34fb418ca45d8999261f44164b1a77ef2" instead of "8.0.0-rc.1"

For all the people who are having trouble with this, I found a workaround fix until we get an official response.

Copy the folder C:\Users\XXXX.dotnet\tools.store\volo.abp.suite\8.0.0-rc.1\volo.abp.suite\8.0.0-rc.1\staticwebassets

To C:\Users\XXXX.dotnet\tools.store\volo.abp.suite\8.0.0-rc.1\volo.abp.suite\8.0.0-rc.1\tools\net8.0\any

and rename it to wwwroot

• ABP Framework version: v8.0.0.rc-1
• UI Type: Angular / MVC / Blazor WASM / Blazor Server
• Database System: EF Core (SQL Server, Oracle, MySQL, PostgreSQL, etc..) / MongoDB
• Tiered (for MVC) or Auth Server Separated (for Angular): yes/no
• Exception message and full stack trace:
• Steps to reproduce the issue:

After upgrading or installing to 8.0.0.rc-1, you can't open ABP Suite, it generates a lot of error

There is also an issue in the file DEMOApplicationTests.cs

There should be a null forgiven in every result.Property or we will be having compilation error. It happens because the result is a nullable variable.

It happens in the following methods.

• public async Task CreateAsync()
• public async Task UpdateAsync()

Hello!

There is an issue in the interface with the following structure

public interface IDEMODbContext : IEfCoreDbContext

The DbSet properties there shouldn't have the null forgiven because it's an interface. There is no template to customize it and even if you fix it, every time you generate it from Suite, a new line with the same error gets created.

There is another issue in the generated EfCoreEntityRepository.cs class

The issue corresponds to the **FindAsync **method inside the **EfCoreRepository ** class

There seems to be a problem between the nullable-enabled project and the non-enabled nullable project (EntityFramework Project).
One method returns a nullable type while the other expects a non-nullable return value.

This is a critical error for the new version.

3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match member "Task<Ubigeo?> IRepository<Ubigeo>.FindAsync(Expression<Func<Ubigeo, bool>> predicate, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" implemented implicitly.    
3>EfCoreUbigeoRepository.cs(14,106): Error CS8613 : Nullability of reference types of the return type of "Task<Ubigeo> EfCoreRepository<DemoDbContext, Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))" does not match the implicitly implemented member "Task<Ubigeo?> IReadOnlyBasicRepository<Ubigeo, Guid>.FindAsync(Guid id, bool includeDetails = true, CancellationToken cancellationToken = default(CancellationToken))".    
3>------- Finished building project: D.EntitemoyFrameworkCore. Succeeded: False. Errors: 2. Warnings: 0    

The solution for this is the following.

In **EfCoreRepository.cs **

Replace this code:

public async override Task<TEntity> FindAsync(   
    Expression<Func<TEntity, bool>> predicate,   
    bool includeDetails = true,   
    CancellationToken cancellationToken = default)   
{   
    return includeDetails   
        ? await (await WithDetailsAsync())   
            .Where(predicate)   
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken))   
        : await (await GetDbSetAsync())   
            .Where(predicate)   
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken));   
}   
   

For this

public async override Task<TEntity?> FindAsync(   
    Expression<Func<TEntity, bool>> predicate,   
    bool includeDetails = true,   
    CancellationToken cancellationToken = default)   
{   
    return includeDetails   
        ? await (await WithDetailsAsync())   
            .Where(predicate)   
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken))   
        : await (await GetDbSetAsync())   
            .Where(predicate)   
            .SingleOrDefaultAsync(GetCancellationToken(cancellationToken));   
}   
   

And replace this code:

public virtual async Task<TEntity> FindAsync(TKey id, bool includeDetails = true, CancellationToken cancellationToken = default)   
{   
    return includeDetails   
        ? await (await WithDetailsAsync()).OrderBy(e => e.Id).FirstOrDefaultAsync(e => e.Id.Equals(id), GetCancellationToken(cancellationToken))   
        : await (await GetDbSetAsync()).FindAsync(new object[] { id }, GetCancellationToken(cancellationToken));   
}   
   

For this one
public virtual async Task<TEntity?> FindAsync(TKey id, bool includeDetails = true, CancellationToken cancellationToken = default)
{
return includeDetails
? await (await WithDetailsAsync()).OrderBy(e => e.Id).FirstOrDefaultAsync(e => e.Id.Equals(id), GetCancellationToken(cancellationToken))
: await (await GetDbSetAsync()).FindAsync(new object[] { id }, GetCancellationToken(cancellationToken));
}

Hi,

Is there any news about this issue?

Thanks!

Hi Rafael, thanks for reporting. We have already fixed this (see https://github.com/abpframework/abp/blob/dev/framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/Domain/Repositories/EntityFrameworkCore/EfCoreRepository.cs#L304) and enabled nullable annotations for all projects of both ABP Framework & ABP Commercial (https://github.com/abpframework/abp/issues/16610) and it will be available in v8.0.

Thanks for your answer!!

Why is not that solution included in 7.4? In my opinion, the fix of EfCoreRepository, it's critical because it can lead to data issues right now. Is it possible to include at least the EfCoreRepository fix only or a temporary workaround?