It seems like the docker compose is setup to create and use a Redis image even when redis is in fact not used in the project. Might not be a problem locally but could be if you deploy to something like Azure and creates a Regis container thinking it is needed when it is not. Maybe this should at least be highlighted in some way as it is probably a good idea to include the redis image as well in the base setup.
On a side note, I was a bit surprised to learn that for new ABP 9 projects, redis does not seem to get installed or configured unless you add the Public Web site, is this true and if so, is that a change from previous or has it always been like that?
I think using a script is more convenient than using Visual Studio, but I'll take a look.
Yes, agreed, but with the "Docker" file being there, it would be good if it was setup for VS. Not sure if that file is actually ever used or just the Docker.local?
The Docker files (ie not Docker.local) are not recognized by Visual Studio, probably because they are not added to the project in the correct way. This means that the Docker functionality in Visual Studio isn't there for publishing etc. as to VS, there exist no Docker files. While you can of course to this yourself, I think it would be nice if it was setup correctly from start, not sure how much extra work it would mean though to get it working with Docker Compose etc.
The health check for SQL server in YAML file will fail
healthcheck: test: /opt/mssql-tools/bin/sqlcmd -S sql-server -U sa -P "myPassw0rd" -Q "SELECT 1" -b -o /dev/null
This both because the sqlcmd seem to have moved to /opt/mssql-tools18/bin/sqlcmd and also as i lacks the -C to accept self signed certificates.
https://github.com/testcontainers/testcontainers-dotnet/issues/1220
Some other improvements
docker-compose.yml still uses
version: '3.8'
which is deprecated (the version attribute that is)
There is a small bug in the build-images-locally.ps1 file, at least for Angular:
Write-Host "********* BUILDING Angular Application *********" -ForegroundColor Green $angularAppFolder = Join-Path $slnFolder "../angular"
This should be ./angular with only one dot as above it, you already have the lines
$currentFolder = $PSScriptRoot $slnFolder = Join-Path $currentFolder "../../"
Or the script wont find the folder (at least assuming you follow the instructions "Navigate to etc/docker-compose folder and run the build-images-locally.ps1 ").
As the previous thread was closed, I create a new one regarding the now re-added Docker (Docker compose) support in ABP Commercial to follow up on improvements and possible problems. Probably a good idea to keep it all in one place rather than creating different tickets for everything (hopefully it won't be much but you never know). Please refund this ticket as the previous one was closed and can not be reopened it seems.
https://abp.io/support/questions/8082/What-is-the-support-for-Docker-in-ABP-Commercial-today
Reopened once again.....
It seems when using the Angular UI and creating Navigation properties, ABP Suite tries to invent the type "Guid" in Angular/Typescript even though that does not exist (at least not by default). If you change it to string it will work both development time and run time it seems.
Is any action being taken on this? It seems like we rarely get feedback on bugs etc reported in this thread compared with when creating new ones, but then general threads like this seems kind of pointless. Thanks.
