The health check for SQL server in YAML file will fail
healthcheck: test: /opt/mssql-tools/bin/sqlcmd -S sql-server -U sa -P "myPassw0rd" -Q "SELECT 1" -b -o /dev/null
This both because the sqlcmd seem to have moved to /opt/mssql-tools18/bin/sqlcmd and also as i lacks the -C to accept self signed certificates.
https://github.com/testcontainers/testcontainers-dotnet/issues/1220
Some other improvements
docker-compose.yml still uses
version: '3.8'
which is deprecated (the version attribute that is)
There is a small bug in the build-images-locally.ps1 file, at least for Angular:
Write-Host "********* BUILDING Angular Application *********" -ForegroundColor Green $angularAppFolder = Join-Path $slnFolder "../angular"
This should be ./angular with only one dot as above it, you already have the lines
$currentFolder = $PSScriptRoot $slnFolder = Join-Path $currentFolder "../../"
Or the script wont find the folder (at least assuming you follow the instructions "Navigate to etc/docker-compose folder and run the build-images-locally.ps1
").
As the previous thread was closed, I create a new one regarding the now re-added Docker (Docker compose) support in ABP Commercial to follow up on improvements and possible problems. Probably a good idea to keep it all in one place rather than creating different tickets for everything (hopefully it won't be much but you never know). Please refund this ticket as the previous one was closed and can not be reopened it seems.
https://abp.io/support/questions/8082/What-is-the-support-for-Docker-in-ABP-Commercial-today
Reopened once again.....
It seems when using the Angular UI and creating Navigation properties, ABP Suite tries to invent the type "Guid" in Angular/Typescript even though that does not exist (at least not by default). If you change it to string it will work both development time and run time it seems.
Is any action being taken on this? It seems like we rarely get feedback on bugs etc reported in this thread compared with when creating new ones, but then general threads like this seems kind of pointless. Thanks.
The problem here
https://abp.io/support/questions/7455/Action-menu-is-displayed-even-if-there-are-no-actions-in-in
was supposed to be fixed in the next release (7 months ago) but is still there, at least in Angular but would imagine in all UI:s since it is probably permission related rather than UI related.