Maximum call stack size exceeded #4188

6 Answer(s)

• 

  0

  muhammedaltug created 2 years ago

  Hello,

  It was fixed with this pr. I will try reproduce the problem again

  Save Cancel
• 

  0

  papusa created 2 years ago

  Hello,

  It was fixed with this pr. I will try reproduce the problem again

  Hi,

  Unfortunately, we still have the issue. It disappeared for a while, but after lates updates it's back :( Even previously suggested workaround doesn't help anymore.

  Did you reproduce the problem? Do you need any additional information?

  Save Cancel
• 

  0

  papusa created 2 years ago

  Hey, any news?

  Save Cancel
• 

  0

  malik.masis created 2 years ago

  Hey, any news?

  Hi,

  The team could reproduce the issue and still working on it. We're trying to let you know asap.

  Fyi / Regards

  Save Cancel
• 

  0

  muhammedaltug created 2 years ago

  Hello,

  We fixed the error. There is a workaround below for avoid this problem

  export class QueueManager {
    private queue: Array<() => void> = [];
    private isRunning = false;
    private stack = 0;
    private interval = 0;
    private stackSize = 100;
  
    public init(interval: number, stackSize: number) {
      this.interval = interval;
      this.stackSize = stackSize;
    }
  
    public add(fn: () => void) {
      this.queue.push(fn);
      this.run();
    }
  
    private run() {
      if (this.isRunning) return;
      this.stack++;
  
      this.isRunning = true;
  
      const fn = this.queue.shift();
  
      if (!fn) {
        this.isRunning = false;
        return;
      }
  
      fn();
      if (this.stack > this.stackSize) {
        setTimeout(() => {
          this.isRunning = false;
          this.run();
          this.stack = 0;
        }, this.interval);
      } else {
        this.isRunning = false;
        this.run();
      }
    }
  }
  
  function checkCustom() {
    if (this.subscription) {
      this.subscription.unsubscribe();
    }
  
    this.subscription = this.permissionService
      .getGrantedPolicy$(this.condition || '')
      .pipe(distinctUntilChanged())
      .subscribe(isGranted => {
        this.vcRef.clear();
        if (isGranted) this.vcRef.createEmbeddedView(this.templateRef);
        if (this.runChangeDetection) {
          if (!this.rendered) {
            this.cdrSubject.next();
          } else {
            this.cdRef.detectChanges();
          }
        } else {
          this.cdRef.markForCheck();
        }
      });
  }
  function after() {
    this.cdrSubject.pipe(take(1)).subscribe(() => {
      this.queue.add(() => {
        this.cdRef.detectChanges();
      });
    });
    this.rendered = true;
  }
  PermissionDirective.prototype['check'] = checkCustom;
  PermissionDirective.prototype['ngAfterViewInit'] = after;
  
  PermissionDirective.prototype['cdrSubject'] = new ReplaySubject();
  PermissionDirective.prototype['rendered'] = false;
  PermissionDirective.prototype['queue'] = new QueueManager();
  
  

  Save Cancel

  1
• 

  0

  papusa created 2 years ago

  Hi,

  Thanks, workaround works. Are you going to include fix for this in next ABP releases?

  Save Cancel