HANGFIRE WORKER/JOB REGISTRATION PROBLEMS ON ABP 8.2.0 #7551

3 Answer(s)

• 

  0

  liangshiwei created 2 years ago

  Fullstack Developer

  https://github.com/abpframework/abp/commits/b9ae57b38bbfe29837079be54bfab31b9949b55a/framework/src/Volo.Abp.BackgroundWorkers.Hangfire/Volo/Abp/BackgroundWorkers/Hangfire/HangfireBackgroundWorkerManager.cs

  The main logic has not changed in a year.

  

  This is not ABP problem, but Hangfire. you can try to change the field length

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel
• 

  0

  andrei.pislaru created 2 years ago

  https://github.com/abpframework/abp/commits/b9ae57b38bbfe29837079be54bfab31b9949b55a/framework/src/Volo.Abp.BackgroundWorkers.Hangfire/Volo/Abp/BackgroundWorkers/Hangfire/HangfireBackgroundWorkerManager.cs

  The main logic has not changed in a year.

  

  This is not ABP problem, but Hangfire. you can try to change the field length

  can you test with the versions i gave you in the screenshot?

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel
• 

  0

  liangshiwei created 2 years ago

  Fullstack Developer

  Hi,

  I will fix it in the next patch version. You can try this

  [Dependency(ReplaceServices = true)]
  [ExposeServices(typeof(IBackgroundWorkerManager), typeof(HangfireBackgroundWorkerManager))]
  public class MyHangfireBackgroundWorkerManager : HangfireBackgroundWorkerManager
  {
      public MyHangfireBackgroundWorkerManager(IServiceProvider serviceProvider) : base(serviceProvider)
      {
      }
  
      public override async Task AddAsync(IBackgroundWorker worker, CancellationToken cancellationToken = default)
      {
          switch (worker)
          {
              case IHangfireBackgroundWorker hangfireBackgroundWorker:
              {
                  var unProxyWorker = ProxyHelper.UnProxy(hangfireBackgroundWorker);
                  if (hangfireBackgroundWorker.RecurringJobId.IsNullOrWhiteSpace())
                  {
                      RecurringJob.AddOrUpdate(
                          () => ((IHangfireBackgroundWorker)unProxyWorker).DoWorkAsync(cancellationToken),
                          hangfireBackgroundWorker.CronExpression, hangfireBackgroundWorker.TimeZone,
                          hangfireBackgroundWorker.Queue);
                  }
                  else
                  {
                      RecurringJob.AddOrUpdate(hangfireBackgroundWorker.RecurringJobId,
                          () => ((IHangfireBackgroundWorker)unProxyWorker).DoWorkAsync(cancellationToken),
                          hangfireBackgroundWorker.CronExpression, hangfireBackgroundWorker.TimeZone,
                          hangfireBackgroundWorker.Queue);
                  }
  
                  break;
              }
              case AsyncPeriodicBackgroundWorkerBase or PeriodicBackgroundWorkerBase:
              {
                  var timer = worker.GetType()
                      .GetProperty("Timer", BindingFlags.Instance | BindingFlags.NonPublic)?.GetValue(worker);
  
                  var period = worker is AsyncPeriodicBackgroundWorkerBase
                      ? ((AbpAsyncTimer?)timer)?.Period
                      : ((AbpTimer?)timer)?.Period;
  
                  if (period == null)
                  {
                      return;
                  }
  
                  var unProxiedType = ProxyHelper.GetUnProxiedType(worker);
                  var adapterType =
                      typeof(HangfirePeriodicBackgroundWorkerAdapter<>).MakeGenericType(unProxiedType);
                  var workerAdapter = (Activator.CreateInstance(adapterType) as IHangfireBackgroundWorker)!;
  
                  RecurringJob.AddOrUpdate(unProxiedType.Name, () => workerAdapter.DoWorkAsync(cancellationToken), GetCron(period.Value),
                      workerAdapter.TimeZone, workerAdapter.Queue);
  
                  break;
              }
              default:
                  await base.AddAsync(worker, cancellationToken);
                  break;
          }
      }
      
      protected override string GetCron(int period)
      {
          var time = TimeSpan.FromMilliseconds(period);
          string cron;
  
          if (time.TotalSeconds <= 59)
          {
              cron = $"*/{time.TotalSeconds} * * * * *";
          }
          else if (time.TotalMinutes <= 59)
          {
              cron = $"*/{time.TotalMinutes} * * * *";
          }
          else if (time.TotalHours <= 23)
          {
              cron = $"0 */{time.TotalHours} * * *";
          }
          else if(time.TotalDays <= 31)
          {
              cron = $"0 0 0 1/{time.TotalDays} * *";
          }
          else
          {
              throw new AbpException(
                  $"Cannot convert period: {period} to cron expression, use HangfireBackgroundWorkerBase to define worker");
          }
  
          return cron;
      }
  }
  

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel