Something is missing to be able to run EF migration to Azure PostgreSQL from within a docker in Github Actions #5492

7 Answer(s)

• 

  0

  maliming created 2 years ago

  Support Team Fullstack Developer

  hi

  You can configure the ConnectionStrings of AbpDbConnectionOptions.

  Save Cancel
• 

  0

  Sturla created 2 years ago

  Hi maliming sorry I don´t understand what you are referring to?

  I am able to get the connection string into my docker image and it is able to try to connect to the server (if I put e.g. a wrong server it reports that there is no such server etc.)

  And from the AbpDbConnectionOptions code and its documentation I can´t see anything that could help me there.

  But there is something in the abp.io framework interfering in the connection but what and why?

  Save Cancel
• 

  0

  maliming created 2 years ago

  Support Team Fullstack Developer

  hi

  If you are using the MyProjectName.DbMigrator you need to put your connection string to appsettings.json.

  https://github.com/abpframework/abp/blob/dev/templates/app/aspnet-core/src/MyCompanyName.MyProjectName.DbMigrator/appsettings.json#L3

  If you already did that, you can write some logs when running the DbMigrator.

  eg: print current connection string.

  please share it if you have custom the code of DbMigrator

  Thanks

  Save Cancel
• 

  0

  Sturla created 2 years ago

  Ok that worked BUTI don´t want to have the database password hardcoded in the docker file/source control. That is not a a future solution!

  I would think that the environment variable should take precedence over the appsettings.json file, correct? It seems like its getting part of the connection string at least since it tries to connect to the server (so it has read that part of the env connection string) but has problem with the password... I don´t get this..

  And I don´t have any custom code at all in my DbMigrator.

  So what do you recommend I do here?

  Save Cancel
• 

  0

  Sturla created 2 years ago

  I managed to make this work but only by using Environment.GetEnvironmentVariable("ConnectionStrings:Default")

  I tried to add AddEnvironmentVariables() to CreateHostBuilder but that didn´t take.

  So here is what I had to do.

  docker run --rm \
  -e ConnectionStrings:Default="$connection_string" \
  ${{ env.DEV_AZURE_CONTAINER_REGISTRY }}/dbmigrator:${{ github.sha }}
  

  and the StartAsync()

  public async Task StartAsync(CancellationToken cancellationToken)
  {
          var envConnectionString = Environment.GetEnvironmentVariable("ConnectionStrings:Default");    
          if (!string.IsNullOrEmpty(envConnectionString))
          {
              _configuration["ConnectionStrings:Default"] = envConnectionString;
              Log.Logger.Information("Using ConnectionStrings:Default from environmental variable");
          }
          
          .... rest of the code..
      }
  }
  

  There was also one other issue and that is I was using a $ in my password and that doesn´t work because the docker run command is running in Linux using bash and then the $ is handled as a variable and it (and following letters) are skipped!

  Save Cancel
• 

  0

  maliming created 2 years ago

  Support Team Fullstack Developer

  So this is a question of how to set and get environment variables. Thanks.

  Save Cancel
• 

  0

  Sturla created 2 years ago

  Yes that´s correct. I chose probably the only symbol that didn´t work.

  But it would be great to know how to enable the env´s and I would even go so far to say that they should be enabled by default...

  Save Cancel