Activities of "jackmcelhinney"

Solved this by overriding the Lepton HeaderBrandViewComponent:

Created Default.cshtml in the Host project at Themes/Lepton/Components/Header/Brand/Default.cshtml:

@using Volo.Abp.Ui.Branding
@using Microsoft.Extensions.Configuration;
@inject IConfiguration _config
@inject IBrandingProvider BrandingProvider
<a class="navbar-brand" href="@_config["App:AngularUrl"]" alt="@BrandingProvider.AppName"></a>

It may be nice at some point to add the href url to the BrandingProvider so those using angular can make all the necessary overrides for the login pages in one place.

Hi maliming,

I've made the following changes but edits to the language texts still only apply in host.

Added DynamicLocalizationResourceContributor (had to get CurrentTenant because the class doesn't extend something with it already)

public class DynamicLocalizationResourceContributor : ILocalizationResourceContributor
{
    protected LocalizationResource Resource;
    protected IDynamicResourceLocalizer DynamicResourceLocalizer;
    protected ICurrentTenant CurrentTenant;

    public void Initialize(LocalizationResourceInitializationContext context)
    {
        Resource = context.Resource;
        DynamicResourceLocalizer = context.ServiceProvider.GetRequiredService<IDynamicResourceLocalizer>();
        CurrentTenant = context.ServiceProvider.GetRequiredService<ICurrentTenant>();
    }

    public LocalizedString GetOrNull(string cultureName, string name)
    {
        using (CurrentTenant.Change(null))
        {
            return DynamicResourceLocalizer.GetOrNull(Resource, cultureName, name);
        }
    }

    public void Fill(string cultureName, Dictionary<string, LocalizedString> dictionary)
    {
        using (CurrentTenant.Change(null))
        {
            DynamicResourceLocalizer.Fill(Resource, cultureName, dictionary);
        }
    }
}

Added the contributor in the HostModule:

Configure<LocalizationResource>(options =>
{
    options.Contributors.Clear();
    options.Contributors.Add(new DynamicLocalizationResourceContributor());
});

Any other suggestions?

Thanks!

ABP Framework Version: v4.4.4 UI Type: Angular DB provider: EF Core Identity Server Separated: No

After upgrading to 4.4.4, my existing project and new projects with no changes both log a ExpressionChangedAfterItHasBeenCheckedError error to the console on app component load.

To reproduce:

1. Create new project from ABP suite
2. Run the initial migration
3. Start the application
4. Open browser developer console

Follow-up on my issue posted above:

Steps to reproduce:

• Create new project through the suite
  • Version: 4.3.3
  • UI type: Angular
  • Identity Server Seperated: No
• Run db-migrator in API, yarn in Angular project
• Start UI and API

• Open localhost:4200 in Incognito
• Clear cookies, local storage, and empty cache and hard reload
• Click Login
• A seemingly random error will log and the css of the login page may or not be missing. The error is usually an issue getting something from the libs folder or styles for the theme.
• Below are some of the errors I have seen while testing this:

My concern is that because it involves the cache, storage, or cookies, this error will only appear for new users coming to the site. Please let me know if you are able to reproduce this.

Thanks!

Hello. I am having a strange issue after updating from 4.2.2 to 4.3.2. When running the app locally, if I open it in a fresh browser like Chrome Incognito, I get the following console errors.

When logging out:

After navigating back to the login page:

This may be difficult to reproduce as I have been unable to do so in the demo app or a fresh project, but has anyone else experienced this or have any suggestions for what might be causing it? I followed the migration guide closely and used WinMerge to update all other changes.

Details:

• Angular UI
• Authorization Code Flow

One other small bug that I noticed was that this dropdown now appears over the button to open it rather than below it:

Hello! Two small bugs to report:

1. With Angular UI, the Administration sidebar menu closes after selecting an element. For example, starting from the Home page, click Administration->Identity Management->Roles. It navigates to the Roles page but the Administration menu collapses. Not sure if this was introduced in 4.1 or 4.2 as we upgraded from 4.0 to 4.2.

2. The lockout message in English could use a few fixes. Please notice the bold and strike-through below.

Your account has been locked by the admin or due to invalid login attempts. Please try again later. Contact ~~to~~ your system administrator if you think this is a mistake.

As always, thanks for the help!

Edit:

Here are two more:

1. With Angular UI, when signed in with an account that does not have any administration permissions, the administration menu button briefly shows when clicking other menu items. This happens frequently but seemingly randomly.
2. The cancel button on the login page does not properly return to the unauthenticated app when using Angular UI. It seems to redirect to http://localhost:4200/?error=access_denied and throws this error in the console:

core.js:4197 ERROR OAuthErrorEvent {type: "code_error", reason: {…}, params: {…}}

You need to replace it in the Host project like so:

More information here: https://support.abp.io/QA/Questions/446/How-do-I-customize-login-pages-for-Angular-when-using-new-Authorization-Work-Flow-in-version-31#answer-38188880-0159-b68b-a717-39f7ea546c59

Hope this helps.

Hello! Two small bugs to report (Angular UI ABP v4.0.2).

1. The My security logs page is missing a Return to Application link like the Manage your profile page has. So there is no way to return without using the browser back button.
2. When editing permissions for a role or user, "Identity Management" is misspelled as "Idetity"

Hi @alper. I mentioned on my original comment that using the built in repository methods like GetAsync(id) are working properly for me as well. The error is only thrown when querying the repository with a LINQ operator like Where(). While my example code for reproducing the issue could be replaced with GetAsync(id), our actual code where we are disabling the UOW has much more complicated queries that cannot be replaced with the repository method. These queries were working before upgrading to 4.0.2 and no other changes have been made.

To reproduce the issue, please try replacing the line in WorkItemAppService.cs with this:

return ObjectMapper.Map<WorkItem, WorkItemDto>(await _workItemRepository.Where(w => w.Id == id).FirstOrDefaultAsync());

Thank you for your help trying to sort this out.

@alper I should have clarifed. I made both of these changes based on the code you suggested. It produces the same error.