Activities of "roberto.fiocchi"

A couple of suggestions for abp suite:

1. When a string attribute in a entity has "Required" checked but "Allow empty string" unchecked the generated code for the entity has the wrong check in the entity's contructor: It uses "Check.NotNull" that will still allow empty strings to pass even tho we dont want them In the Manager this is already correct since it uses "Check.NotNullOrWhiteSpace" which will not allow empty strings
2. Make it so that abp suite still works when not connected to a network, it failes to get login-info and it wont start
3. Abp suite as of now doesn't allow a string attribute to have the same minimum length and maximum length, it would be useful to have this feature since some attribute might have a fixed length.

Would be nice to be able to download all the templates in Abp Suite without having to modify each one manually to retrieve it, this would help to notice the differences in the templates in newer versions. Ref: https://docs.abp.io/en/commercial/latest/abp-suite/editing-templates

https://support.abp.io/QA/Questions/3052/Your-feature-request#answer-3a0d62be-d186-9460-0995-e613ddc33fbf

I would like the advanced filter to be generated optionally (for all UI types)

Thank you

This works:

protected List<PermissionGrantInfoDto> GetChildPermissions(PermissionGroupDto permissionGroup, PermissionGrantInfoDto permission)
{
    var childPermissions = new List<PermissionGrantInfoDto>();
    GetChildPermissions(childPermissions, permissionGroup.Permissions, permission);
    return childPermissions;
}

protected void GetChildPermissions(List<PermissionGrantInfoDto> allChildPermissions, List<PermissionGrantInfoDto> permissions, PermissionGrantInfoDto permission)
{
    var childPermissions = permissions.Where(x => x.ParentName == permission.Name).ToList();
    if (childPermissions.Count == 0)
    {
        return;
    }

    allChildPermissions.AddRange(childPermissions);

    foreach (var childPermission in childPermissions)
    {
        GetChildPermissions(allChildPermissions, permissions, childPermission);
    }
}

hi,

It seems to me that as of today this is a requirment since the permission modal wont work properly if it isn't respected, What is the point of having the PermissionDefinition.AddChild() function and nesting them if the rest of the implementation doesn't use this structure?

hi,

Thanks for the link, but this didn't answer my questions:

Is this a naming convention for the permissions that Abp enforces? If so, could you link us the documentation that defines this naming convention?

Hi,

I have overriden the PermissionManagmentModal and now im able to see the sublevels, but i have noticed that when i uncheck a parent permission the child permissions dont get unchecked. After further investigation i have found this piece of code in the PermissionManagmentModal:

protected List<PermissionGrantInfoDto> GetChildPermissions(PermissionGroupDto permissionGroup, PermissionGrantInfoDto permission)
{
    return permissionGroup.Permissions.Where(x => x.Name.StartsWith(permission.Name)).ToList();
}

This assumes that the child (and child's child and so on) permissions all start with parent permission Name. Our permission naming follows a different logic, Is this a naming convention for the permissions that Abp enforces? If so, could you link us the documentation that defines this naming convention?

Hi,

Thanks for the reply! Is there any possibility to have that feature in version 7.4.5? We would rather not migrate to .Net 8 yet.

In the 8.0.0 version of Abp Suite with the new version of EntityFramework that supports the DateOnly and TimeOnly types, it would be useful to add them to the list of types that can be used to create a property in an entity.

Hi, yes you are right the other filters should also be passed to the parameter and the filtering should work for them as well. I have created an internal issue (#15729) for this and will fix it asap.

Also, is it not wiser to use a POST request rather then a GET because the query parameters in a GET requests has a 2048 character limit and could possibly go over if i have enough filters?

I understand your intent but since we are getting a result back and not adding or updating any record to a datastore, and instead just collecting the result and returning it GET request seems more proper, according to REST API guides.

Hi, Thanks so much for the help and understanding! We'll wait for the fix.

P.S: We don't know if its intended but we also noticed that with ABP 7.4.2 under HttpApi project a "TestModel.cs" is created when initializing the project with Abp Suite