Angular - MCP Support UI: Address PR review feedback #21701

Back

Addresses all reviewer feedback from the MCP support UI PR.

Changes

  • [class] over [ngClass] — Replaced all [ngClass] bindings in mcp-connections-modal.component.html with the modern [class] directive per Angular migration guide
  • Signal queries — Migrated @ViewChild decorators to viewChild() signal queries in chat-interface.component.ts; updated all call sites accordingly
  • Semantic pagination buttons — Replaced <a href="javascript:void(0)"> with <button type="button"> for prev/next pagination in workspace-data-sources.component.html
  • routerLink navigation — Replaced hard href with [routerLink] in select-mcp-server-modal.component.html to preserve Angular Router state; added RouterLink to component imports

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)
  • I worked with the design team to get their idea for UI/UX design (or no need to design for this PR)
  • I've assigned reviewer, related labels and set a milestone for this PR

How to test it?

Checkout branch issue/test-mcp-for-ng (#21697) and verify MCP connections modal renders transport type icons/badges correctly, pagination buttons function without page reload, and the "New MCP Server" link navigates without a hard refresh.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Version
10.2.0-rc.1
Release Date
24 February, 2026
Labels
No labels
1
ABP Assistant
🔐 You need to be logged in to use the chatbot. Please log in first.