Custom implementation of IAuthorizationMiddlewareResultHandler does not provide details to client when navigating to a page from browser URL #2075

5 Answer(s)

• 

  0

  liangshiwei created 5 years ago

  Fullstack Developer

  Hi,

  Can you provide steps to reproduce? thanks.

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel
• 

  0

  alexander.nikonov created 5 years ago

  Hi. Here is the reproducable situation in the test project attached. Let's say I'm trying to access http://localhost:4200/dashboard via typing the address in a browser and the logged user does not have access to this page. IAuthorizationMiddlewareResultHandlerimplementation is even not triggered - straight away default 403 forbidden is shown.

  P.S. Could you please add possibility to attach code zip archives to a message? It's not user-friendly to create cloud links each time.

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel
• 

  0

  liangshiwei created 5 years ago

  Fullstack Developer

  Hi,

  I will check it.

  You will notice that I deleted the file link, because your license is included in the source code, I don't think you want to disclose it :)

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel
• 

  0

  liangshiwei created 5 years ago

  Fullstack Developer

  Hi,

  Try:

  [Dependency(ReplaceServices = true)]
  [ExposeServices(typeof(IMethodInvocationAuthorizationService))]
  public class MyMethodInvocationAuthorizationService : IMethodInvocationAuthorizationService, ITransientDependency
  {
      private readonly IAbpAuthorizationPolicyProvider _abpAuthorizationPolicyProvider;
      private readonly IAbpAuthorizationService _abpAuthorizationService;
  
      public MyMethodInvocationAuthorizationService(IAbpAuthorizationPolicyProvider abpAuthorizationPolicyProvider, IAbpAuthorizationService abpAuthorizationService)
      {
          _abpAuthorizationPolicyProvider = abpAuthorizationPolicyProvider;
          _abpAuthorizationService = abpAuthorizationService;
      }
  
      public async Task CheckAsync(MethodInvocationAuthorizationContext context)
      {
          if (AllowAnonymous(context))
          {
              return;
          }
  
          var authorizationPolicy = await AuthorizationPolicy.CombineAsync(
              _abpAuthorizationPolicyProvider,
              GetAuthorizationDataAttributes(context.Method)
          );
  
          if (authorizationPolicy == null)
          {
              return;
          }
  
  
          var result = await _abpAuthorizationService.AuthorizeAsync(authorizationPolicy);
  
          if (!result.Succeeded)
          {
              var requirements = result.Failure.FailedRequirements;
  
              var missingPermissionBuilder = new StringBuilder();
  
              foreach (var requirement in requirements)
              {
                  if (requirement is PermissionRequirement abpRequirement)
                  {
                      missingPermissionBuilder.AppendLine(abpRequirement.PermissionName);
                  }
              }
  
              throw new AuthorizationException(
                  $"The next permissions are required:\r\n\r\n{missingPermissionBuilder}");
          }
      }
  
      protected virtual bool AllowAnonymous(MethodInvocationAuthorizationContext context)
      {
          return context.Method.GetCustomAttributes(true).OfType<IAllowAnonymous>().Any();
      }
  
      protected virtual IEnumerable<IAuthorizeData> GetAuthorizationDataAttributes(MethodInfo methodInfo)
      {
          var attributes = methodInfo
              .GetCustomAttributes(true)
              .OfType<IAuthorizeData>();
  
          if (methodInfo.IsPublic && methodInfo.DeclaringType != null)
          {
              attributes = attributes
                  .Union(
                      methodInfo.DeclaringType
                          .GetCustomAttributes(true)
                          .OfType<IAuthorizeData>()
                  );
          }
  
          return attributes;
      }
  }
  

  Is this what you want?

  

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel
• 

  0

  liangshiwei created 5 years ago

  Fullstack Developer

  Re-open if still not work.

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel