LastModification fields not updated when changing one-to-many relationship #10057

12 Answer(s)

• 

  0

  AI-Bot created 21 days ago

  Support Team ABP Agent

  1. Solution

  • Root cause

    • In ABP, modification audit properties (LastModificationTime/LastModifierId) are set by ApplyAbpConcepts during SaveChanges only when EF Core reports the entity as Modified. Historically, changing only a navigation/foreign key could be missed by EF change detection, so audit fields were not updated.
    • From ABP 8.3 onward, the framework explicitly updates ModificationAuditProperties when a navigation property changes. On earlier versions (like 9.2.3 is newer than 8.3, so it already includes this behavior), you should get updates if the FK or navigation change is tracked as a modification within the same DbContext/Unit of Work.

  • What to verify in your app

    1. Ensure updates happen inside a Unit of Work and the same DbContext instance tracks the entity and the FK change before SaveChanges.
       • Use repository.GetAsync(id), mutate tracked entity’s AuthorId (or navigation), then await repository.UpdateAsync(entity, autoSave: true) or rely on UoW completion.
    2. Change the FK scalar property, not only the navigation proxy:

  var book = await _bookRepository.GetAsync(id);
       book.AuthorId = input.AuthorId; // set the FK scalar
       // or set book.Author = await _authorRepository.GetAsync(input.AuthorId);
       await _bookRepository.UpdateAsync(book, autoSave: true);
  

  3. Do not use ExecuteUpdate/ExecuteDelete bulk operations for this scenario; they bypass EF tracking, so ABP auditing (including modification audit fields) will not run.
  4. Make sure CurrentUser is available if you expect LastModifierId. If the operation is AllowAnonymous or executed by background processes, LastModifierId may be null unless you set a principal:

  var claims = new List<Claim> { new Claim(AbpClaimTypes.UserId, userId.ToString()) };
       using (_currentPrincipalAccessor.Change(claims))
       {
           await _bookRepository.UpdateAsync(book, autoSave: true);
       }
  

  5. If you’re attaching a detached entity (e.g., mapping DTO to new entity instance and calling UpdateAsync), ensure EF knows which properties changed. Prefer fetch-and-mutate; otherwise you may need to mark the FK property as modified on the DbContext entry.

  • ABP 8.3+ behavior (applies to 9.2.3)

    • ABP updates ModificationAuditProperties when navigation properties change. If you still see no update:
      • Confirm that AuthorId change results in EF change tracker marking the entity as Modified.
      • Confirm the change is not done via raw SQL or bulk update APIs.
      • Confirm the update path is not suppressing ApplyAbpConcepts (e.g., custom DbContext SaveChanges override that skips base behavior).

  • Minimal working example

  public class BookAppService : ApplicationService
    {
        private readonly IRepository<Book, long> _bookRepository;
  
        public BookAppService(IRepository<Book, long> bookRepository)
        {
            _bookRepository = bookRepository;
        }
  
        public async Task UpdateAuthorAsync(long id, long? newAuthorId)
        {
            var book = await _bookRepository.GetAsync(id); // tracked
            book.AuthorId = newAuthorId;
            await _bookRepository.UpdateAsync(book, autoSave: true); // triggers ApplyAbpConcepts
            // After save, LastModificationTime and LastModifierId should be updated (if CurrentUser.Id exists)
        }
    }
  

  • If you must use detached updates

  var book = await _bookRepository.GetAsync(id);
    _ = ObjectMapper.Map(input, book); // ensure AuthorId ends up different
    await _bookRepository.UpdateAsync(book, autoSave: true);
  

  • Summary
    • With ABP 9.2.3, changing a FK/navigation should update LastModificationTime/LastModifierId provided:
      • The change is tracked by EF in a normal UoW (not bulk ops/raw SQL).
      • You change the entity instance fetched from repository (tracked).
      • CurrentUser is set if you expect LastModifierId.
    • If your code path still does not update the audit fields, refactor to fetch-and-mutate within the repository/UoW as shown above.

  2. Sources

  • https://abp.io/docs/latest/release-info/migration-guides/abp-8-3
  • https://abp.io/support/questions/6298
  • https://abp.io/community/articles/zvr01mtn

  ---

  This response was generated by AI. If it didn’t solve your problem, feel free to post a new answer — our support team will jump in to help you soon.

  Save Cancel
• 

  0

  tim.delandtsheer created 21 days ago

  Hi,

  We already tried suggestions of the AI-bot .

  • We are updating by ID. (no navigation property). In EF Core, the Id is configured as a foreign key by default.
  • We are using the default generated code from ABP-Suite. So tracked entity, explicit update. Not directly on the database.

  Save Cancel
• 

  0

  maliming created 21 days ago

  Support Team Fullstack Developer

  hi

  We've created a new simple ABP project to reproduce, and the same behaviour happens.

  Can you share the test project to liming.ma@volosoft.com?

  Thanks.

  Save Cancel
• 

  0

  maliming created 18 days ago

  Support Team Fullstack Developer

  hi

  I have downloaded the AbpShowcase project. Can you share the steps?

  Thanks.

  Save Cancel
• 

  0

  tim.delandtsheer created 18 days ago

  Hi, some steps for the test-project to reproduce

  Getting project ready (its a simple ABP Starter)

  1. Instal libs (nuget, yarn)
  2. Run SQL-migrations (DbMigrator)
  3. Run Application (Host)

  Reproduce issue

  1. Navigate to "Genres" and create 2 to 3 genres. They are required to select in the next steps.
  2. Navigate to "Books" and create a new book. Fill in a single genre in the dropdown and some other fields. In the database, creation-audit fields are filled in. (Expected)
  3. Open the edit modal of the book, edit some fields and save. In the database, modification-audit fields are filled in. (Expected)
  4. Open the edit modal again and ONLY update the genre dropdown: pick another value and save. In the database, modification-audit fields are not changed. We expect them to be updated, because the field GenreId is updated.

  Save Cancel
• 

  0

  maliming created 18 days ago

  Support Team Fullstack Developer

  hi

  The relationship of Genres and Movies is Many-to-Many instead of One-To-Many

  Save Cancel
• 

  0

  tim.delandtsheer created 18 days ago

  Hi

  We have both a many-to-many and a one-to-many on our test-entity, as shown on the screenshot below. The bug is about the one-to-many, when changing the dropdown on the "main"-tab.

  Save Cancel
• 

  0

  maliming created 18 days ago

  Support Team Fullstack Developer

  hi

  I will check it again.

  Thanks.

  Save Cancel
• 

  0

  maliming created 18 days ago

  Support Team Fullstack Developer

  hi

  Please try to override the PublishEventsForChangedEntityOnSaveChangeAsync and PublishEventsForTrackedEntity methods and test again.

  Thanks.

  [ReplaceDbContext(typeof(IIdentityProDbContext))]
  [ConnectionStringName("Default")]
  public class AbpShowcaseDbContext :
      AbpDbContext<AbpShowcaseDbContext>,
      IIdentityProDbContext
  {
  
      public AbpShowcaseDbContext(DbContextOptions<AbpShowcaseDbContext> options)
          : base(options)
      {
  
      }
  
      protected override Task PublishEventsForChangedEntityOnSaveChangeAsync()
      {
          foreach (var entityEntry in AbpEfCoreNavigationHelper.GetChangedEntityEntries())
          {
              if (EntityChangeOptions.Value.PublishEntityUpdatedEventWhenNavigationChanges)
              {
                  var ignoredEntity = EntityChangeOptions.Value.IgnoredNavigationEntitySelectors.Any(selector => selector.Predicate(entityEntry.Entity.GetType()));
                  var onlyForeignKeyModifiedEntity = entityEntry.State == EntityState.Modified && entityEntry.Properties.Where(x => x.IsModified).All(x => x.Metadata.IsForeignKey());
  
                  if ((entityEntry.State == EntityState.Unchanged && ignoredEntity) || ignoredEntity)
                  {
                      continue;
                  }
  
                  if (EntityChangeOptions.Value.UpdateAggregateRootWhenNavigationChanges &&
                      EntityChangeOptions.Value.IgnoredUpdateAggregateRootSelectors.All(selector => !selector.Predicate(entityEntry.Entity.GetType())) &&
                      entityEntry.State == EntityState.Unchanged)
                  {
                      ApplyAbpConceptsForModifiedEntity(entityEntry, true);
                  }
  
                  if (entityEntry.Entity is ISoftDelete && entityEntry.Entity.As<ISoftDelete>().IsDeleted)
                  {
                      EntityChangeEventHelper.PublishEntityDeletedEvent(entityEntry.Entity);
                  }
                  else
                  {
                      EntityChangeEventHelper.PublishEntityUpdatedEvent(entityEntry.Entity);
                  }
              }
              else if (entityEntry.Properties.Any(x => x.IsModified && (x.Metadata.ValueGenerated == ValueGenerated.Never || x.Metadata.ValueGenerated == ValueGenerated.OnAdd)))
              {
                  if (entityEntry.Properties.Where(x => x.IsModified).All(x => x.Metadata.IsForeignKey()))
                  {
                      // Skip `PublishEntityDeletedEvent/PublishEntityUpdatedEvent` if only foreign keys have changed.
                      break;
                  }
  
                  if (entityEntry.Entity is ISoftDelete && entityEntry.Entity.As<ISoftDelete>().IsDeleted)
                  {
                      EntityChangeEventHelper.PublishEntityDeletedEvent(entityEntry.Entity);
                  }
                  else
                  {
                      EntityChangeEventHelper.PublishEntityUpdatedEvent(entityEntry.Entity);
                  }
              }
          }
  
          return Task.CompletedTask;
      }
  
      protected override void PublishEventsForTrackedEntity(EntityEntry entry)
      {
          switch (entry.State)
          {
              case EntityState.Added:
                  ApplyAbpConceptsForAddedEntity(entry);
                  EntityChangeEventHelper.PublishEntityCreatedEvent(entry.Entity);
                  break;
  
              case EntityState.Modified:
                  if (entry.Properties.Any(x => x.IsModified && (x.Metadata.ValueGenerated == ValueGenerated.Never || x.Metadata.ValueGenerated == ValueGenerated.OnAdd)))
                  {
                      // if (entry.Properties.Where(x => x.IsModified).All(x => x.Metadata.IsForeignKey()))
                      // {
                      //     // Skip `PublishEntityDeletedEvent/PublishEntityUpdatedEvent` if only foreign keys have changed.
                      //     break;
                      // }
  
                      ApplyAbpConceptsForModifiedEntity(entry);
                      if (entry.Entity is ISoftDelete && entry.Entity.As<ISoftDelete>().IsDeleted)
                      {
                          EntityChangeEventHelper.PublishEntityDeletedEvent(entry.Entity);
                      }
                      else
                      {
                          EntityChangeEventHelper.PublishEntityUpdatedEvent(entry.Entity);
                      }
                  }
                  else if (EntityChangeOptions.Value.PublishEntityUpdatedEventWhenNavigationChanges &&
                           EntityChangeOptions.Value.IgnoredNavigationEntitySelectors.All(selector => !selector.Predicate(entry.Entity.GetType())) &&
                           AbpEfCoreNavigationHelper.IsNavigationEntryModified(entry))
                  {
                      if (EntityChangeOptions.Value.UpdateAggregateRootWhenNavigationChanges &&
                          EntityChangeOptions.Value.IgnoredUpdateAggregateRootSelectors.All(selector => !selector.Predicate(entry.Entity.GetType())))
                      {
                          ApplyAbpConceptsForModifiedEntity(entry, true);
                      }
  
                      if (entry.Entity is ISoftDelete && entry.Entity.As<ISoftDelete>().IsDeleted)
                      {
                          EntityChangeEventHelper.PublishEntityDeletedEvent(entry.Entity);
                      }
                      else
                      {
                          EntityChangeEventHelper.PublishEntityUpdatedEvent(entry.Entity);
                      }
                  }
                  break;
  
              case EntityState.Deleted:
                  ApplyAbpConceptsForDeletedEntity(entry);
                  EntityChangeEventHelper.PublishEntityDeletedEvent(entry.Entity);
                  break;
          }
      }
  
  

  Save Cancel
• 

  0

  tim.delandtsheer created 17 days ago

  Hi,

  It seems to work with the given overrides. However, it's sad that by implementing these overrides we have the risks of possible missing feature updates and even future breaking changes.

  Is this a temporary fix until a stable solution in the packages of ABP? Or will it be configurable in a next version?

  Save Cancel
• 

  0

  maliming created 17 days ago

  Support Team Fullstack Developer

  hi

  We will improve it in the next 9.3.x patch version.

  Thanks.

  Save Cancel
• 

  0

  tim.delandtsheer created 17 days ago

  Okay thanks!

  Save Cancel