AI Management: a workspace with an empty Embedder Provider ('') still adds the search_documents RAG tool to every chat call #10901

1 Answer(s)

• 

  0

  maliming created yesterday

  Support Team Fullstack Developer

  Hi,

  This is a bug. The workspace configuration treats an empty EmbedderProvider as configured, and the Workspaces page saves empty fields as ''.

  For now, you can add this class to your Application project (it runs in the HttpApi.Host in your tiered solution). It saves empty providers as NULL when a workspace is created, updated or duplicated:

  using System;
  using System.Collections.Generic;
  using System.Threading.Tasks;
  using Volo.Abp.DependencyInjection;
  using Volo.Abp.Domain.Repositories;
  using Volo.AIManagement.ApplicationWorkspaceProviders;
  using Volo.AIManagement.McpServers;
  using Volo.AIManagement.VectorStores;
  using Volo.AIManagement.WorkspaceDataSources;
  using Volo.AIManagement.Workspaces;
  
  namespace MyCompanyName.MyProjectName;
  
  [Dependency(ReplaceServices = true)]
  [ExposeServices(typeof(IWorkspaceAppService), typeof(WorkspaceAppService))]
  public class MyWorkspaceAppService : WorkspaceAppService
  {
      public MyWorkspaceAppService(
          IWorkspaceRepository repository,
          IRepository<ApplicationAIProvider, Guid> applicationWorkspaceProviderRepository,
          IMcpServerRepository mcpServerRepository,
          ApplicationWorkspaceManager applicationWorkspaceManager,
          VectorStoreInitializer vectorStoreInitializer,
          IEnumerable<IVectorStoreFactory> vectorStoreFactories,
          IWorkspaceDataSourceAppService workspaceDataSourceAppService)
          : base(
              repository,
              applicationWorkspaceProviderRepository,
              mcpServerRepository,
              applicationWorkspaceManager,
              vectorStoreInitializer,
              vectorStoreFactories,
              workspaceDataSourceAppService)
      {
      }
  
      public override Task<WorkspaceDetailDto> CreateAsync(WorkspaceCreateInput input)
      {
          input.EmbedderProvider = NullIfWhiteSpace(input.EmbedderProvider);
          input.VectorStoreProvider = NullIfWhiteSpace(input.VectorStoreProvider);
          return base.CreateAsync(input);
      }
  
      public override async Task<WorkspaceDetailDto> UpdateAsync(Guid id, WorkspaceUpdateInput input)
      {
          input.EmbedderProvider = NullIfWhiteSpace(input.EmbedderProvider);
          input.VectorStoreProvider = NullIfWhiteSpace(input.VectorStoreProvider);
  
          // Normalize the stored values first, so '' -> NULL is not treated as an embedder change
          var workspace = await Repository.GetAsync(id);
          var embedderProvider = NullIfWhiteSpace(workspace.EmbedderProvider);
          var vectorStoreProvider = NullIfWhiteSpace(workspace.VectorStoreProvider);
          if (workspace.EmbedderProvider != embedderProvider || workspace.VectorStoreProvider != vectorStoreProvider)
          {
              workspace.EmbedderProvider = embedderProvider;
              workspace.VectorStoreProvider = vectorStoreProvider;
              await Repository.UpdateAsync(workspace, autoSave: true);
          }
  
          return await base.UpdateAsync(id, input);
      }
  
      public override async Task<WorkspaceDetailDto> DuplicateAsync(Guid id, WorkspaceDuplicateInput input)
      {
          var result = await base.DuplicateAsync(id, input);
          await CurrentUnitOfWork!.SaveChangesAsync();
  
          var workspace = await Repository.GetAsync(result.Id);
          workspace.EmbedderProvider = NullIfWhiteSpace(workspace.EmbedderProvider);
          workspace.VectorStoreProvider = NullIfWhiteSpace(workspace.VectorStoreProvider);
          await Repository.UpdateAsync(workspace);
  
          return ObjectMapper.Map<Workspace, WorkspaceDetailDto>(workspace);
      }
  
      private static string? NullIfWhiteSpace(string? value)
      {
          return string.IsNullOrWhiteSpace(value) ? null : value;
      }
  }
  

  After you deploy it:

  1. Open each workspace that has no embedder in the UI and save it once. This changes the stored '' values to NULL.
  2. Remove the cached workspace configurations, including the entries cached for tenants. Run this against the Redis server your applications use (add -h, -p, -n and -a to both redis-cli calls as needed):

  redis-cli --scan --pattern '*Volo.AIManagement.Factory.ChatClientCreationConfiguration*' | while IFS= read -r key; do redis-cli del "$key"; done
  

  If you use the default in-memory cache instead of Redis, skip this step. The restart in the next step clears it.

  3. Restart your applications (HttpApi.Host and Blazor), so no running chat client keeps the old configuration.

  After that, the search_documents tool is no longer added for these workspaces, and later edits in the UI keep the values as NULL.

  We'll also fix this in the AI Management module.

  Thanks

  Markdown supported.

  Copy, paste, or drag & drop images and files (max 100 MB per file, 100 MB total per post)

  Save Cancel