Provide us with the following info:
- ABP Framework version: v7.3.1
- UI Type: MVC
- Database System: EF Core (SQL Server)
- Tiered (for MVC) or Auth Server Separated (for Angular): no
- Exception message and full stack trace:
- Steps to reproduce the issue:
The documentation for customising MVC states the following:
This indicates that the LogoReverseUrl will be used on when the dark theme is selected. However, the code in SideMenuLayout.cshtml does exactly the opposite:
Is this a problem in the documentation or the code?
6 Answer(s)
-
0
Hi phil@travelengine.com.au ,
Refer below image which is having dark theme with logo-light.svg
Refer below image which is having light theme with logo-dark.svg
As its showing that the code is based on the documentation.
-
0
What are the values for
LogoUrlandLogoReverseUrlset on yourIBrandingProviderThe styles you are showing on the right appear to have come from the .css file. IBrandingProvider values are injected directly into the header and override the CSS like this.
-
0
Hi phil@travelengine.com.au,
We are agree with you that IBrandingProvider overrides the CSS. But as mentioned in the documentation
logoUrlis used to show app logo only andlogoReverseUrlis used as per the theme selected that means- If for
Darktheme url isLogoUrlthen forLighttheme it will beLogoReverseUrl - If for
Lighttheme url isLogoUrlthen forDarktheme it will beLogoReversUrl
This is only given for example.
I hope your doubt will be clear. Thanks,
- If for
-
0
Hello phil@travelengine.com.au,
Please let us know is there anything else that we can help you with?
Can we close this ticket if your query is resolved? Please confirm.
Thank You, Anjali
-
0
I am sorry Anjali but I am no wiser on how this is supposed to work.
The documentation says that
LogoReverseUrlonIBrandingProvidershould specify the application logo on a reverse color theme. This is ambiguous because 'reverse' means it is the relative to something else, but what that something else is, is not clear.In an apparent attempt to clarify the documentation then says '(dark, for example)'. It is worded in a very confusing way and IMHO the documentation should be made much clearer - particularly for something that virtually very ABP user will want to customise right out of the box.
It also seems to be absolutely the opposite of what
SideMenuLayout.cshtmlactually does -- that component will cause the variable--lpx-logoto be set to IBrandingProvider.LogoReverseUrl for.lpx-theme-light, or to IBrandingProvider.LogoUrl for.lpx-theme-darkor.lpx-theme-dim.So I still have no answer to my original question - the documentation and the code are total opposites of each other.
-
0
Hi phil@travelengine.com.au
Yes, there was a confusing implementation for BrandingProvider. We've just made some changes and improved it. It'll work same as documentation says in the next release of LeptonX.
