Activities of "developer1"

Hi,

@gvnuysal's message remind me of this: Suite: open/edit a navigation -> cancel -> save and cancel buttons are disabled. Maybe already on some list, but i am to lazy to find out. ;-)

Erik

Hi Alper, @alper

Template

Frontend.Mvc.Page.Partials.editcshtml_cs_LookupDropdownOnGet.txt

is wrong.

%%np-entity-name%%LookupList.AddRange((
                        await _%%entity-name-camelcase%%AppService.Get%%np-entity-name%%LookupAsync(new LookupRequestDto 
                        { xxxxxx
                            MaxResultCount = LimitedResultRequestDto.MaxMaxResultCount 
                        })).Items.Select(t => new SelectListItem(t.DisplayName, t.Id.ToString())).ToList()
            );

This is just to simple. You cannot release this as stable to paying customers.

I have seen other critical responses here. I also feel like I'm a tester. In last version, lookup dropdown did not work at all. I have been patiant. But you cannot ask this from paying customers.

I dare you to present me an example of an Angular/EF project created with generate-proxy / suite. I never got it towork in the last months.

This should realy get better Alper. My advise: maintain stable versions, like Telerik does. Now you solve one and create the next issue.

Erik

Hi alper,

I've compiled a list with issues the last few weeks. Some maybe already addressed, but most i'm sure are not.

Use it how you like.

NOK:

Suite: (4.0.0.rc-4)

• Cannot read the template Volo.Abp.Commercial.SuiteTemplates.Templates.Frontend.Mvc.Page.Partials.createcshtml_LookupDropdownInput.txt

Navigation

• No relations, FK and Indexes are created, - at all -. This is NOK !!
• Angular Suite/crud creation is (still) not working ok. (3.3.1)
• MVC: Lookup dash bug (filters and edit/add) "The following errors were detected during validation. The value '—' is not valid for xxxx (FK field like OrderId). this is because of: "new SelectListItem(" — ", null) (search for it)

Incomplete: (4.0.0)

• Allow parent-child navigation in same entity. (not working. try it.) (Hierarchy tables, works fine in abp)
• Navigation prop are incomplete (always). IE: Order|Order-line: I should see order-line-List in Order.
• There is something wrong with memo fields. I think when it is 0 - 0 range? S.Q.L breaks in migration. It should not be a v a r c h a r (0), but v a r c h a r (M A X)

Enum issues:

• Enum {Flags} decorator : Enum values like 0x2, 2 « 1. =˃ as a min, Calculate them, to decimal?!
• or better: read them and allow with multiple choice (1,2,4,8,16,32,...)
• Enum value comments give errors. (use them or ignore them please)
• Enum values attributes give errors. (use them or ignore)

Requests, enrich your product with:

• Allow navigation prop to be null or required.
• Set a default Entity "Description" property (a check, like sort), so referencing entities know what to show. (ref to contact knows .Name is the default description field)
• Calulated properties. (Add {NotMapped} to Entity property)
• Crud: Allow remarks to class (in suite, entity etc.)
• Crud: Allow remarks/comment to properties (in suite, properties,)
• Allow "partial" for classes. And allow creation of default partial counterparts; second file: Order.cs =˃ generates also Order.Business.cs (partial of Order)
• Allow "use in UI", "Show in main index table", "edit in UI" (like ABP)
• Allow and document use of vars in templates; Why can't I use %%database-table-name%% in 'Server.Entity.Entity.txt' ??
• Allow default vars also, like date/time, and statics for documenting.
• Allow indexes on properties.
• Allow UNIQUE indexes on properties. (ie The field 'name' is usique)

Hi Alper!

yes, i did. I think. ;-)

Suite log:

2020-10-21 17:10:08.972 +02:00 [ERR] ---------- RemoteServiceErrorInfo ----------
{
  "code": null,
  "message": "An internal error occurred during your request!",
  "details": null,
  "data": {},
  "validationErrors": null
}

2020-10-21 17:10:08.975 +02:00 [ERR] Value cannot be null. (Parameter 'path1')
System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
   at System.IO.Path.Combine(String path1, String path2, String path3)
   at Volo.Abp.Suite.Areas.AbpSuite.CrudPageGenerator.Services.AngularSchematicsService.GetAngularSchematicsInstallationDirectory(String angularSolutionRootPath)
   at Volo.Abp.Suite.Areas.AbpSuite.CrudPageGenerator.Services.AngularSchematicsService.eZ5m9BvNde(String  )
   at Volo.Abp.Suite.Areas.AbpSuite.CrudPageGenerator.Services.AngularSchematicsService.YfEmdGsZsL(String  )
   at Volo.Abp.Suite.Areas.AbpSuite.CrudPageGenerator.Services.AngularSchematicsService.SetupSchematicsAsync(Solution solution)
   at Volo.Abp.Suite.Areas.AbpSuite.CrudPageGenerator.Services.TemplateManagementService.GetTemplatesAsync(Guid solutionId)
   at Volo.Abp.Suite.Controllers.TemplatesController.GetTemplatesAsync(String solutionId)
   at lambda_method(Closure , Object )
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableObjectResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.&lt;InvokeNextActionFilterAsync&gt;g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.&lt;InvokeNextExceptionFilterAsync&gt;g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)

Hi,

**1. **Blocking issue in Suite: (app + mod)

• updated suite to 3.3.0-rc.1
• Not updated abp (global)
• Start suite and create new app (or mod, makes no dif) with preview checked
• Compile, upd-db, works fine
• Suite: Add a new entity > internal error
• Suite: Edit templates > internal error Easy to reproduce; very blocking. Probably the change of the entity templates within the solution (good move)

2. When you decorate enumerations, this will mess up everything. ie:

    /// <summary>
    ///     The type of service
    /// </summary>
    [Flags]
    public enum ServiceTypes
    {
        /// <summary>Not set, used or initialised</summary>
        [Description("Not Set")]
        NotSet = 0,

        [Description("Action Container")]
        ActionContainer = 1,

        . . . 
    }

Critical note: It happens a lot lately, that just strait forward things, do just not work. So: just create an App, or Mod, add a module and a Crud. This should not be hard to test, right? This should not give errors -- even-- in pre-releases.

That said. Great work. So rich, fast delivery. Kudos. Hope I contributed something. ;-)

Erik